search

opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
119 stars 9 forks source link

Continued timing issues on keyboard shortcuts #180

Open dmusican opened 2 years ago

dmusican commented 2 years ago

I'm using Nostalgy++ 3.4.2, with TB 91.9.1.

This isn't a new issue, but I couldn't figure out if this was connected to the previous posted issues. I continue to have challenges where sometimes Nostalgy++ doesn't pick up my keyboard shortcuts and will instead pass them through to TB. I'll hit S to save a message, and the email will get starred, for example. I can't always predict when it will happen, but I can make it happen predictably when I hit the shortcut quickly after returning to the TB main window after being in another window (e.g, via alt-tab). I'll also sometimes just see the Nostalgy++ preferences appear unexpectedly as a result of a key I'm hitting (I'm not sure which one), but

Is there anything that can done to improve the timing on this? I've lost track of a number of emails by accident because I'll type S, then start typing the folder name before I realize that Nostalgy++ hasn't caught the keyboards... and then the letters I added in the folder name end up going through as commands directly to TB (sometimes with ugly results).

Thanks for all of your work! TB is so much more usable as a result of having this add-on.

opto commented 1 year ago

it would be best to choose letters in the options that are not in use by TB.

We override TB by 'keydown' or 'keypressed' listeners. These may not be active in all areas of the window, or may need time to become active?

dmusican commented 1 year ago

FYI, redefining the keyboard shortcuts to be different than those in use by TB does solve this problem. I've remapped "Save Message" to alt-S, and "Go to folder" as alt-O, and the timing problem has completely disappeared. So many thanks for that workaround.