search

opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
119 stars 9 forks source link

Compose Dialog Settings for CC and BCC have no Effect 102.0.3 #187

Closed szmontsaroff closed 1 year ago

szmontsaroff commented 2 years ago

Setting "Always show CC/BCC line in compose has no effect on this release of thunderbird.

opto commented 2 years ago

found the change in TB, working here already

szmontsaroff commented 2 years ago

Does this mean it will be supported in a future release?

reagle commented 2 years ago

I'm wondering if this might be related to #186 ?

hkclark commented 1 year ago

I'm having this same issue. @opto When you say "working here already", do we need to do something on our end to get your fix? I'm at 3.6.1 (I'm letting the normal upgrade process in TBird upgrade me when it finds a new version). Thanks.

opto commented 1 year ago

I am confused. It is not working in the version from ATN, so maybe I have not yet uploaded it, or maybe the compose dialog has changed again (they changed function names and ids etc. for 102).

reagle commented 1 year ago

I'm not sure where this setting is, but I think it's specific to account settings and I have cc/bcc ticked, but not addresses, and I think this meant always include those headers, but it doesn't in thunderbird 102.3.1 . SCR-20221003-d23 SCR-20221003-d1w

opto commented 1 year ago

please try this: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.3

@reagle: it is not that. This means a setting in the options where you can decide to always show the cc or bcc lines in compose dialog.

hkclark commented 1 year ago

@opto Works great for me! You are a hero. Thank you!

hi5 commented 1 year ago

please try this: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.3

@reagle: it is not that. This means a setting in the options where you can decide to always show the cc or bcc lines in compose dialog.

When I turn "show CC" on and I hit reply (all) on an email the caret is in the "TO:" field and not in the body - if I turn it off again the caret is in the body of the email and I can start typing as usual.

Edit: windows 10, 64bit, TB 102.3.0/2

hkclark commented 1 year ago

When I turn "show CC" on and I hit reply (all) on an email the caret is in the "TO:" field and not in the body - if I turn it off again the caret is in the body of the email and I can start typing as usual.

Yes, I have noticed that "slight annoyance" as well. But otherwise, it's working great for me.

mewalter commented 1 year ago

Same issue for me with the cursor ending up in the "To" field. Just need to remember to hit tab a few times to get it to the body. Benefits of Nostalgy++ far outweigh this minor inconvenience.

hi5 commented 1 year ago

I'm guessing the focus can be set to the body somehow so it is good to report such things.

opto commented 1 year ago

yes, thanks for reporting. Can it be fixed? Depends on how to distinguish in the code reply (all) from write, where it would make sense to have cursor in to.

hi5 commented 1 year ago

Perhaps: IF subject.hascontent() THEN setfocus.body() the reason being that a reply (all) would always have something in the subject line where as writing a new email in many case won't have one yet (e.g. subject is empty) - of course one can think of cases where the subject line does have content and there is no TO but my guess that would be rare.

opto commented 1 year ago

please try this. It also revives esc esc to get into the body: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.5

mewalter commented 1 year ago

This definitely works when using reply or reply-all. Thanks.

Minor problem is that when using Forward, it also sets focus in the message body. For Forward the expected behavior would be to set focus in the To field. Looks like the approach of using IF subject.hascontent() does neglects the fact that a forwarded message will have a subject but has a blank To field. Sorry,

I am completely ignorant with the code. Is there are "IF to.hascontent()" call? If so, is that the way to go?

opto commented 1 year ago

yes and no, because there are the 'crazy' pills showing the addresses. So one would do:? if to empty and subject present, go to to?

opto commented 1 year ago

you still can go there by esc followed by t

hi5 commented 1 year ago

please try this. It also revives esc esc to get into the body: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.5

Works for me, thanks 👍 as does esc-esc, esc-t, esc-c

With regards to forwarding

if to empty and subject present, go to to?

sounds reasonable if possible

opto commented 1 year ago

3.6.11 is in review so close this

opto commented 1 year ago

for forward focus issue: https://github.com/opto/nostalgy-xpi/releases/tag/v3.6.13