opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
122 stars 9 forks source link

Update to TB 128/Nebula: asking for donations #210

Open opto opened 1 year ago

opto commented 1 year ago

There are a lot of changes in TB 115 (and now TB 128 which is still being totally rewritten)), because the main window has been converted to html, and many global access points to internal functions have been moved, renamed or are gone.

So the addon update for this TB update (115) is really a lot of work, so donations are very much appreciated.

Donations by Paypal: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=6K57TUFSNMVSJ&source=url

EDIT: the news on TB 128 are ca. 142 posts further down

many thanks, Klaus

moritzp commented 1 year ago

Screenshot 2023-09-18 at 09 54 50 The current styling in the configuration doesn't allow to read the text.

ULinn commented 1 year ago

Just donated, thank you Klaus for your Work. I'd be happy to test the next version, I will be really happy when I have my shortcuts to move my mails back ;-) Uli

fanf commented 1 year ago

@opto

yes, best here, preferably with the version no. (4.0.1 this time)

Yes 4.0.1

I retested, it seems to work sometimes (repeating, it will move on the second or third try). When I originally tested, i think it worked always.

What OS do you have (I a on win 11-64

I'm on arch linux, Thnuderbird 115.2.0 (64-bit) (not sur if you need some software/framework version?)

mdonz commented 1 year ago

Using Thunderbird 115.2.3 on Ubuntu, Nostalgy 4.0.1 I notice two issues: a) when using the preference "Restrict folder completion to the current server" (as I used with all former Nostalgy versions, no matches are found for folder names with move or copy operations. When I disable that Preference, the folders are found as before. b) when trying to use the key for "show messages with same sender/subject" (my most often used key), I see an error message: "Cannot perform this action when QuickSearch is not enabled"

petersnows25 commented 1 year ago

Thanks alot for all the work. I have been using it for a long time, best Thunderbird addon. . Just donated!

opto commented 1 year ago

intermittently moving messages: this is a TB issue? because doCommandWithFolder(Components.interfaces.nsMsgViewCommandType.moveMessages, folder); on and off does not move.

There are other ways in code to move messages, I will try them.

fanf commented 1 year ago

@opto

yes, best here, preferably with the version no. (4.0.1 this time)

Yes 4.0.1

I retested, it seems to work sometimes (repeating, it will move on the second or third try). When I originally tested, i think it worked always. What OS do you have (I a on win 11-64

I'm on arch linux, Thnuderbird 115.2.0 (64-bit) (not sur if you need some software/framework version?)

Updating to TB 115.2.2 made moving works !

fanf commented 1 year ago

So, I was a bit too optimistic: moving works /sometimes/ and I was not able to understand when/how/why, which is extermely frustrating. I thought it was link with "does thunderbird is doing something like downloading messages", and it looked like, but no - or not completly (perhaps just correlation, not causation).

fanf commented 1 year ago

If it helps, here are the logs for when it works / does not work:

console.log: WebExtensions: in impl: isMailTab true
console.log: "isMailTab" true
## that happens when TB window get back focus
console.log: "services" ({uuid:({}), domStorageManager:({}), telemetry:({}), els:({}), sysinfo:({}), obs:({}), intl:({}), prompt:({}), prefs:({}), DAPTelemetry:({}), appShell:({}), cookieBanners:({}), vc:({}), logins:({}), dns:({}), textToSubURI:({}), storage:({}), xulStore:({}), blocklist:({}), urlFormatter:({}), perms:({}), locale:({}), sessionStorage:({}), clearData:({}), env:({}), scriptloader:({}), io:({}), focus:({}), DOMRequest:({}), fog:({}), profiler:({}), search:({}), qms:({}), strings:({}), policies:({}), eTLD:({}), loadContextInfo:({}), ppmm:{}, appinfo:({}), droppedLinkHandler:({}), console:({}), ww:({}), uriFixup:({}), catMan:({}), scriptSecurityManager:({}), clipboard:({}), dirsvc:({}), wm:({}), tm:({}), cache2:({}), startup:({}), mm:{}, cpmm:{}, cookies:({})}) "this" ({})
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
## around here, I try to move previously selected emails: hit 'M' ('S' replacement for me), start writing target directory, 
## move to the correct choice, hit enter 
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
[ERROR style::stylesheets::rule_parser] Saw @import rule, but no way to trigger the load
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: "NostalgyDefLabel" (void 0)
console.log: WebExtensions: in impl: isMailTab false
console.log: "isMailTab" false
console.log: "NostalgyDefLabel" (void 0)
console.log: WebExtensions: in impl: isMailTab false
console.log: "isMailTab" false
console.log: "NostalgyDefLabel" (void 0)
console.log: WebExtensions: in impl: isMailTab true
console.log: "isMailTab" true
## I'm not sure where exactly, but I retried a latter to move, and that time it worked, between here:
## <-----
console.log: "services" ({uuid:({}), domStorageManager:({}), telemetry:({}), els:({}), sysinfo:({}), obs:({}), intl:({}), prompt:({}), prefs:({}), DAPTelemetry:({}), appShell:({}), cookieBanners:({}), vc:({}), logins:({}), dns:({}), textToSubURI:({}), storage:({}), xulStore:({}), blocklist:({}), urlFormatter:({}), perms:({}), locale:({}), sessionStorage:({}), clearData:({}), env:({}), scriptloader:({}), io:({}), focus:({}), DOMRequest:({}), fog:({}), profiler:({}), search:({}), qms:({}), strings:({}), policies:({}), eTLD:({}), loadContextInfo:({}), ppmm:{}, appinfo:({}), droppedLinkHandler:({}), console:({}), ww:({}), uriFixup:({}), catMan:({}), scriptSecurityManager:({}), clipboard:({}), dirsvc:({}), wm:({}), tm:({}), cache2:({}), startup:({}), mm:{}, cpmm:{}, cookies:({})}) "this" ({})
console.log: WebExtensions: in impl: isMailTab false
console.log: "isMailTab" false
console.log: "NostalgyDefLabel" (void 0)
console.log: WebExtensions: in impl: isMailTab true
console.log: "isMailTab" true
console.log: "services" ({uuid:({}), domStorageManager:({}), telemetry:({}), els:({}), sysinfo:({}), obs:({}), intl:({}), prompt:({}), prefs:({}), DAPTelemetry:({}), appShell:({}), cookieBanners:({}), vc:({}), logins:({}), dns:({}), textToSubURI:({}), storage:({}), xulStore:({}), blocklist:({}), urlFormatter:({}), perms:({}), locale:({}), sessionStorage:({}), clearData:({}), env:({}), scriptloader:({}), io:({}), focus:({}), DOMRequest:({}), fog:({}), profiler:({}), search:({}), qms:({}), strings:({}), policies:({}), eTLD:({}), loadContextInfo:({}), ppmm:{}, appinfo:({}), droppedLinkHandler:({}), console:({}), ww:({}), uriFixup:({}), catMan:({}), scriptSecurityManager:({}), clipboard:({}), dirsvc:({}), wm:({}), tm:({}), cache2:({}), startup:({}), mm:{}, cpmm:{}, cookies:({})}) "this" ({})
console.log: WebExtensions: in impl: isMailTab false
console.log: "isMailTab" false
## ----> and here

Not sur it helps (it doesn't help me for sure :) )

opto commented 1 year ago

https://github.com/opto/nostalgy-xpi/releases/tag/4.0.2

this version uses move from the webextention side.

Contra: they haven't yet implemented undo for this (ctrl-z). So if you send the mails into the wrong folder, you cannot get them back by ctrl-z.

I will try to restore the old behaviour, but if this works, other issues may be more important right now.

opto commented 1 year ago

@fanf Interesting, my code does not have any @import

opto commented 1 year ago

@mdonz found this: Restrict folder completion to the current server, will come tomorrow

show messages with same sender/subject does not do anything here, but maybe it is the wrong letter for German TB

opto commented 1 year ago

@mdonz: same sender/subject should be fixable because I find quickfilter input box in expression search, so I need to pull that code

opto commented 1 year ago

@mdonz that doesn't look so easy, because that searchbox changed its code a lot.

but don't we have this in quicker quicksearch or in expression search?

mdonz commented 1 year ago

https://github.com/opto/nostalgy-xpi/releases/tag/4.0.2

this version uses move from the webextention side. Move now seems to work here consistently.

mdonz commented 1 year ago

@mdonz found this: Restrict folder completion to the current server, will come tomorrow Great. Thanks

mdonz commented 1 year ago

but don't we have this in quicker quicksearch or in expression search?

Sorry, don't understand that. Do you mean the TB built-in Quick-Filter. I used a single keystroke (shortcut) to show all emails from the same sender or with the same subject heavily and would miss it a lot. Thanks for your work on this!

opto commented 1 year ago

no, I have another addon called quicker quicksearch which can do that https://addons.thunderbird.net/de/thunderbird/addon/quicker-quicksearch/?src=ss

mdonz commented 1 year ago

Ah, did not know about that. For me it's almost as good as what I had before with the former nostalgy shortcut but I am happy to use that addon instead. Thanks.

dbergol commented 1 year ago

Hi opto, thanks for the great work. I work on Win10-64bit, TB 115.2.2 64bit. I have some issues with new version 4.0.2

DrCheese-mac commented 1 year ago

Happy to contribute if you can get PayPal to accept donations from New Zealand.

sinkva commented 1 year ago

Quicker quicksearch documentation "bugs" (sorry, I can't find the v2.6 repository in Github): "Ctrl+Alt+H: copy domain to quicksearch box" should say "copy subject..." For MacOS, please add a note saying the modifier keys are "Command-Option" Thanks!

r2evans commented 1 year ago

I remapped the move key from the traditional S to W; I can no longer type in part of a folder.

For instance, if my folder hierarchy is:

- Inbox
    |- Drafts
    |- Sent
    |- Banking
        |- Bank1
        |- Bank2

then when on a message, I used to be able to hit S (now W) and type in Bank1 and it would auto-complete to Inbox/Banks/Bank1. That no longer works. I can hit space and it shows the recent history that shows Inbox/Banks/Bank1, but even selecting that results in a "No folder Inbox/Banks/Bank1" popup (though the folder is there).

Completion options:

image

TB 115.2.3, Nostalgy++ 4.0.2

console log (Sorry for the console vomit.)
1695408973597   addons.xpi  WARN    Checking /usr/lib/thunderbird/distribution/extensions for addons
1695408974098   addons.webextension.cloud@johannes-endres.de    WARN    Loading extension 'cloud@johannes-endres.de': Reading manifest: Warning processing cloud_file.data_format: This property is deprecated
1695408974210   addons.xpi  WARN    Addon with ID thunderbird-compact-light@mozilla.org already installed, older version will be disabled
1695408974211   addons.xpi  WARN    Addon with ID thunderbird-compact-dark@mozilla.org already installed, older version will be disabled
Found 0 public keys and 0 secret keys (0 protected, 0 unprotected) [RNPLib.jsm:551:15](chrome://openpgp/content/modules/RNPLib.jsm)
Successfully loaded optional OpenPGP library libgpgme.so.11 from system's standard library locations [GPGMELib.jsm:64:13](chrome://openpgp/content/modules/GPGMELib.jsm)
gpgme version: 1.18.0 [GPGMELib.jsm:236:15](chrome://openpgp/content/modules/GPGMELib.jsm)
Uncaught ReferenceError: module is not defined
     moz-extension://f86a3add-7791-4250-bf9a-3c70ab32147e/punycode/punycode.js:440
[punycode.js:440:1](moz-extension://f86a3add-7791-4250-bf9a-3c70ab32147e/punycode/punycode.js)
     moz-extension://f86a3add-7791-4250-bf9a-3c70ab32147e/punycode/punycode.js:440
cachePrefs [static.js:117:14](moz-extension://134618c0-0fae-4f32-a330-815373dcd381/utils/static.js)
SLStatic.setLogConsoleLevel(info) [static.js:56:14](moz-extension://134618c0-0fae-4f32-a330-815373dcd381/utils/static.js)
This instance's UUID: {3fa22537-6b40-4df2-a268-31a7ce9feb31} [background.js:901:16](moz-extension://134618c0-0fae-4f32-a330-815373dcd381/background.js)
onSafeActivated [me-background.js:35:11](moz-extension://b9c8b73a-3492-4265-b1da-7d713632b75b/me-background.js)
new label 
dmusican commented 1 year ago

I just donated. Thank you so much for your work!

waltermelow commented 1 year ago

Done! a little donation. Thank you for your work!

moritzp commented 1 year ago

However, I observed a weird and reproducable behaviour when trying to move messages: I'm pressing the shortcut key, type some characters to find the folder. In that case, the string within the Nostalgy bar is expanded to the suggested folder and "selected". If I then press Enter, the message is moved AND opened in a separate tab, which is also focussed. If I press "arrow down" before pressing Enter, and thereby selecting the entry from the list, the message is moved and not opened in a separate tab, which I consider as the expected behaviour.

This issue actually became different with the newest version: Now the mails selected are not moved anymore, but only opened. So if I, e.g. selected a thread of 5 messages, all of them are opened.

Also, the "go to folder" shortcut doesn't seem to work. I assigned multiple different keys to check it, but none does the trick 🥺

Still the same, too :(

kohlhase commented 1 year ago

However, I observed a weird and reproducable behaviour when trying to move messages: I'm pressing the shortcut key, type some characters to find the folder. In that case, the string within the Nostalgy bar is expanded to the suggested folder and "selected". If I then press Enter, the message is moved AND opened in a separate tab, which is also focussed. If I press "arrow down" before pressing Enter, and thereby selecting the entry from the list, the message is moved and not opened in a separate tab, which I consider as the expected behaviour.

This issue actually became different with the newest version: Now the mails selected are not moved anymore, but only opened. So if I, e.g. selected a thread of 5 messages, all of them are opened.

I had the same problem, when I type the first couple of letters of the folder into the input field. If you hit tab after that, and then return the messages will be moved. So I can live with that. But I liked the tab-less interaction much better.

Also, the "go to folder" shortcut doesn't seem to work. I assigned multiple different keys to check it, but none does the trick 🥺

Still the same, too :(

Same for me with TB 15.3.0 on Macos Ventura

pnevmati commented 1 year ago

Just donated. I cannot live without Nostalgy! :)

cwittern commented 1 year ago

Dear @opto, tried to donate from Japan, but in the end it says, donations currently not available from this country. I have had issues like this before, PayPal for some reason rarely, if ever, allows donations from Japan. So it might be worthwhile to think about other avenues as well (not that I have any suggestions).
Since I very much depend on Nostalgy++, I am currently holding back upgrading to TB115 until the dust settles a bit more.
Thank you very much for your work!

pnevmati commented 1 year ago

Dear all, @opto, using Thunderbird 115.3.0 and Nostalgy++ 4.0.2 if I save a message to a folder it does not show at the "undo" option. Do others get the same behavior?

LasXor commented 1 year ago

Dear all, @opto, using Thunderbird 115.3.0 and Nostalgy++ 4.0.2 if I save a message to a folder it does not show at the "undo" option. Do others get the same behavior?

This behavior is known and explicitly stated in the release notes of the 4.0.2 release

CockyCaucasian commented 1 year ago

Just donated. Sorry to ask a possibly dumb question but when do you think is the new version going to be ready? Just trying to decide if I should wait or try to downgrade TB. Can't live without Nostalgy!

CockyCaucasian commented 1 year ago

Just donated. Sorry to ask a possibly dumb question but when do you think is the new version going to be ready? Just trying to decide if I should wait or try to downgrade TB. Can't live without Nostalgy!

Ok, figured it out. For some reason version 4.0.2 would not install under TB 115, but today it did. Ignore my previous message.

riccardocazzola commented 1 year ago

Using 4.0.2. on TB 115.2.2 on LINUX the move command(S) does nothing when hit from message view, while it works when in the mail list page Sound strange that this is a bug only for me, so I would like to know if is possible that I have missed some configuration the explain this behaviour

stodec commented 1 year ago

Just donated, thank you for your work!

h-ish commented 1 year ago

mdonz:

"Donations to this recipient aren't supported in this country" (Paypal states) - that's me trying to contribute from New Zealand.

I've tried to donate from Japan and got the error message below, which means the same as above.

この受取人への寄付は、この国ではサポートされていません

mdhoney commented 1 year ago

Donated! Thanks Klaus for all you do. Nostalgy++ is absolutely essential to my email workflow by now...

SKova1965 commented 1 year ago

Donated in the last couple of months. I really appreciate your work on Nostalgy++, it is a great addition. Just updated to 115 last night, will try the 4.0,2 code to see how it works.

opto commented 1 year ago

for those where a tab with the email opens:

for unknown reasons, the folder must be selected with the up/down keys. Even when it is already written into the box, please select it in the selection box with up/down key, then it moves - both from inboxor subfolders

opto commented 1 year ago

new version with webextention copy: more reliable, but no build in undo (yet, announced by TB to be coming)

https://github.com/opto/nostalgy-xpi/releases/tag/v4.0.3

kohlhase commented 1 year ago

for those where a tab with the email opens:

for unknown reasons, the folder must be selected with the up/down keys. Even when it is already written into the box, please select it in the selection box with up/down key, then it moves - both from inboxor subfolders

Writing the folder name into the box and confirming it with a tab also works.

dbergol commented 1 year ago

Dear opto

great work continues, moving from any subfolder to another works again like a charm - fantastic! I have one more question: are there plans to support a shortcut to go to a folder ("g") again? I am desparetely missing it, because I use many nested folders and sometimes can't find them anymore ;-)

Best Daniel

kohlhase commented 1 year ago

I support that! g is sorely missing.

opto commented 1 year ago

yes, g will come, I scanned the core code yesterday night for how they do it now, and it will come in today f tomorrow, if it works out of the box

opto commented 1 year ago

this verson does "go", unless the folder is hidden by the current view (see comment in release)

https://github.com/opto/nostalgy-xpi/releases/tag/v4.0.4

hkclark commented 1 year ago

@opto Thank you for the new releases!! Can you say more on what you mean by "if folder is not in the current view, it will not be displayed"? I'm not sure what I would do to hide or not hide a folder in the current view. Thank you again.

henning commented 1 year ago

well, I donated already multiple times, but after the Thunderbird update, nostalgy++ is turned off for not being compatible.

What can I do?

I dont understand what the latest releases mean, either...

They are said to be from 1 / 16 hours ago, but the source code is the same.

Is development happening now without git versioning and some binaries uploaded for releases??

opto commented 1 year ago

@henning: yes, at the moment the changes are only on my notebook. If you have been forced to 115, you can manually load the version I published. extra-addons-cog symbol-load from file. But it has not been finally tested, on the other hand, there are no detrimentous reports here on functions that are revived - and what isn't updated yet,that obviously does not work yet.

@hkclark: above the folder display at the three dots, you can choose folder views. If you chose favorites, for example, and a folder you want to go to is not in the favorites, we cannot display it currenztly (old Nostalgy would switch the views to find one where a folder can be displayed, and with time, that will come back)

hkclark commented 1 year ago

@hkclark: above the folder display at the three dots, you can choose folder views. If you chose favorites, for example, and a folder you want to go to is not in the favorites, we cannot display it currenztly (old Nostalgy would switch the views to find one where a folder can be displayed, and with time, that will come back)

@opto Thank you for the explanation! It makes sense now. Thanks for all the hard work on Nostalgy++!

HGuillemet commented 1 year ago

for those where a tab with the email opens: for unknown reasons, the folder must be selected with the up/down keys. Even when it is already written into the box, please select it in the selection box with up/down key, then it moves - both from inboxor subfolders

Writing the folder name into the box and confirming it with a tab also works.

This works indeed, but is not very handy. Hitting return before tab will activate whatever has the focus. It it's the mail, it will open in a new tab, but it can be any control. For instance I just activated a button that sends a spam report by mistake because I didn't type Tab before typing Return. So this is a bit annoying, any way to fix this ?

Another problem: sometimes (I haven't figure out when exactly) after saving a mail, the viewport into the table of the inbox jumps forward, instead of staying where it is and showing the message following the saved message.