opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
122 stars 9 forks source link

Update to TB 128/Nebula: asking for donations #210

Open opto opened 1 year ago

opto commented 1 year ago

There are a lot of changes in TB 115 (and now TB 128 which is still being totally rewritten)), because the main window has been converted to html, and many global access points to internal functions have been moved, renamed or are gone.

So the addon update for this TB update (115) is really a lot of work, so donations are very much appreciated.

Donations by Paypal: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=6K57TUFSNMVSJ&source=url

EDIT: the news on TB 128 are ca. 142 posts further down

many thanks, Klaus

ecogit commented 3 months ago

Not knowing where a user forum is or if there is one, I will misuse this to ask if it is time to upgrade TB to 115 or just stick with 102 for awhile longer. My main reason for delay has been nostalgy++. Life is crazy for me, and I did not want to deal with the things that TB changed to make opto (talk about crazy life!) and the rest of us miserable. So 115? "Is it safe?" (said Olivier to Hoffman)

@cjholly As far as I know the key functions of nostalgy++ work well on TB 115. I think some search functions and hot-key customisations are still limited. Personally I use it on TB 115 since over half a year without any issues or shortcomings. Maybe someone else can elaborate more precisely.

olx54 commented 3 months ago

Donate. I wait for new version for TB128 @opto, an idea for the date ?

kohlhase commented 3 months ago

I also donated, and I am desparately waiting for an update for TB128, not having nostalgy s, c, and g, probably costs me 20 min a day spent on of pointy clicky annoying interactions. I am almost at the point of switching away from TB (but there are few non-pointy-clicky alternatives).

opto commented 3 months ago

Thanks for all your support.

I think I will put a first test version up here about this weekend or early next week. Maybenot all working, but I think the basic moving is working. On some systems, we have timing problems at startup of TB (TB parts and addon startetd in the wrong order). But it is worth trying.

kohlhase commented 3 months ago

that is great news! Thanks for your work.

opto commented 3 months ago

I had planned to upload, but: the same code is working on 128.0 but not on 128.1.1

So ... please wait somewhat later, I need to find out what changed in core TB between 128.0 and 128.1.1.

If you want to clamp your version to 128.0, please let me know, then I can upload that Nostalgy version for 128.0.

thanks,

Klaus

sinkva commented 3 months ago

I just donated yet again, since (for me) Thunderbird is unusable without Nostalgy's "S"ave, "C"opy, and "G"o... Thank you @opto for all your work on this!

opto commented 3 months ago

first version/TB 128 for testing and for comments: https://github.com/opto/nostalgy-xpi/releases/tag/v4.1.13

kohlhase commented 3 months ago

I just installed that, in TB 128.1.1esr and s, S, and g (these are the most important ones for me) work like a charm. Thanks a lot for your update. Now I can work down my huuuuge inbox again.

kohlhase commented 3 months ago

Here is one little thing I noticed. If I select a whole thread of e-mails and hit s, then only the first one is moved. That used to be more convenient. (Maybe I am also not clear on what "I select a whole thread" is in TB 128

olx54 commented 3 months ago

On 28/08/2024 12:13, Klaus Buecher wrote:

first version/TB 128 for testing and for comments: https://github.com/opto/nostalgy-xpi/releases/tag/v4.1.13

— Reply to this email directly, view it on GitHub https://github.com/opto/nostalgy-xpi/issues/210#issuecomment-2314903992, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TY32ERW4ILN6GU2OIJ3TZTWPE5AVCNFSM6AAAAAAZ6PBOUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUHEYDGOJZGI. You are receiving this because you commented.Message ID: @.***>

Thanks for this version.

I found one bug and one difficulty.

Bug : when the extension is installed, it is impossible to open the menu Tools/Adds-o, and Themes. Without the extension, it works fine.

Difficulty : I have assigned the key A for Save message. But this key open the message for Reply to all. Without the extension, the problem is the same (A is normally for Archive)

-- Olivier LACROIX - Réseau Lothaire Université de Lorraine / Direction du Numérique / Infrastructures & Services

Château du Montet @.*** Rue du Doyen Roubault | +33 (0)3.72.74.11.52 54500 Vandoeuvre-lès-Nancy |

Contacts réseau Lothaire : @.*** / +33 (0)3.72.74.12.12 /http://lothaire.univ-lorraine.fr/

opto commented 3 months ago

@kohlhase : a thread of messages or only several unconnected selected messages?

The latter does work here, my test installation does not have message threads, so I cannot test the first there.

opto commented 3 months ago

@olx54 :what OS do you have? Both works for me on Win 11-64. The themes open, and also I can replace the S by A and it opens the folder selection box.

olx54 commented 3 months ago

Le 28/08/2024 à 16:24, Klaus Buecher a écrit :

@olx54 https://github.com/olx54 :what OS do you have? Both works for me on Win 11-64. The themes open, and also I can replace the S by A and it opens the folder selection box.

— Reply to this email directly, view it on GitHub https://github.com/opto/nostalgy-xpi/issues/210#issuecomment-2315483812, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TY33BO5XFF73XYGTZRQDZTXMQPAVCNFSM6AAAAAAZ6PBOUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVGQ4DGOBRGI. You are receiving this because you were mentioned.Message ID: @.***>

I use MacOS Sonoma 14.6.1

-- Olivier LACROIX - Réseau Lothaire Université de Lorraine / Direction du Numérique / Infrastructures & Services

Château du Montet @.*** Rue du Doyen Roubault | +33 (0)3.72.74.11.52 54500 Vandoeuvre-lès-Nancy |

Contacts réseau Lothaire : @.*** / +33 (0)3.72.74.12.12 /http://lothaire.univ-lorraine.fr/

opto commented 3 months ago

oh, unfortunately, I do not have access to a MAC, so I cannot test

kohlhase commented 3 months ago

@kohlhase : a thread of messages or only several unconnected selected messages?

The latter does work here, my test installation does not have message threads, so I cannot test the first there.

Sorry, I should have been more specific. In the tile in the message pane I had collapsed the answers and selected the tile like so. Screenshot 2024-08-28 at 17 21 15 and then I hit the s in the expectation that the whole thread would be moved (If I drag it then all of the messages are dragged), but only the first one was. I am using the last MacOS Sonoma 14.6.1 (latest)

dmusican commented 3 months ago

I am having the same problem @olx54 reported, in that I can no longer open the add-ons tab at all. Either trying to access "Tools, Add-ons and Themes" from the menu, or trying to select "Add-ons and themes" from the three-horizontal-line menu fails to work.

I'm running in Linux, specifically, Ubuntu 24.04.

When I do try to open the add-ons screen, here is the error message that pops up in Error Console:

Uncaught (in promise) TypeError: evt.originalTarget is undefined
    openTab chrome://nostalgy/content/edit_prefs.js:729
    openContentTab chrome://communicator/content/utilityOverlay.js:248
    openAddonsMgr chrome://messenger/content/mailCore.js:600
    openAddonsMgr chrome://messenger/content/mailCore.js:572
    oncommand chrome://messenger/content/messenger.xhtml:1
[edit_prefs.js:729:17](chrome://nostalgy/content/edit_prefs.js)
opto commented 3 months ago

Don't use the new version?

It somehow disables the addon tab, so it can only be deinstalled in safe mode.

But the Nostalgy move/copy etc. seems to work. But if you don't know about safe mode, it is better to wait.

opto commented 3 months ago

for fix see https://github.com/opto/nostalgy-xpi/releases/tag/v4.1.14

dmusican commented 3 months ago

Thank you so much for all of your work! 4.1.14 fixes the add-on tab problem for me.

ghost commented 3 months ago

Donated for 115 and now again for 128 - thanks a lot for your work - for me it works perfectly again!!

olx54 commented 3 months ago

Le 29/08/2024 à 14:29, Dave Musicant a écrit :

Thank you so much for all of your work! 4.1.14 fixes the add-on tab problem for me.

— Reply to this email directly, view it on GitHub https://github.com/opto/nostalgy-xpi/issues/210#issuecomment-2317514354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7TY3ZYYUMUM7KPB774SVTZT4HZNAVCNFSM6AAAAAAZ6PBOUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXGUYTIMZVGQ. You are receiving this because you were mentioned.Message ID: @.***>

For me too. Thanks.

-- Olivier LACROIX

slusallek commented 3 months ago

Happy to report that all I need for moving emails works for me (Kubuntu 24.10, Snap). Added another donation!

Thanks a lot,

Philipp

Am 28.08.24 um 12:13 schrieb Klaus Buecher:

first version/TB 128 for testing and for comments: https://github.com/opto/nostalgy-xpi/releases/tag/v4.1.13 https://github.com/opto/nostalgy-xpi/releases/tag/v4.1.13

— Reply to this email directly, view it on GitHub https://github.com/opto/nostalgy-xpi/issues/210#issuecomment-2314903992, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDSSJXENDTX3YMHJDLNJQLZTWPEZAVCNFSM6AAAAAAZ6PBOUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJUHEYDGOJZGI. You are receiving this because you were mentioned.Message ID: @.***>

--

Please send all meeting/call invitations to: @.***

Prof. Dr.-Ing. Philipp Slusallek

Professor for Computer Graphics at Saarland University Scientific Director, Research Department Agents & Simulated Reality Executive Director, DFKI Saarbrücken Member of the DFKI Executive Board

Saarland University Department of Computer Science Saarland Informatics Campus, E1.1 66123 Saarbrücken, Germany


oschulz commented 3 months ago

New version works fine on my 128.0.1 - thanks so much @opto !

ecogit commented 2 months ago

With latest version (v4.1.14 from Aug 29), most important shortcuts and actions fly well on my 128er Thunderbirds (Pop!_OS / Ubuntu and Windows 11).

Thanks for the adaption @opto, I just donated again 🍻`

barrythrew commented 2 months ago

When trying to move a collapsed thread, v4.1.14 only moves one message at a time, not the entire thread.

Remiol commented 2 months ago

Can you please change permissions of your add-on? Current permission: Have full, unrestricted access to Thunderbird, and your computer

opto commented 2 months ago

unfortunately, that is not possible. The addon needs access to Thnderbird (e.g. to prepare folder lists, listen for the pressed keys). The addon does not access your computer.

Unfortunately, the Thunderbird team has combined those two warnings into one. They provide only one permission level, although "access Thunderbird" would be sufficient.

The addon is reviewed by Thunderbird team members in person before download is allowed. They wouldn't allow bad actions (admittedly, if they see it in the code).

After being reviewed, it is not possible to add any bad action to the code, because the code then is on their server for download.

The team wants us addon authors to move to the new addon style which can be reviewed automatically (but also those addons could delete all your mailbox, if you give the delete permission). So they are not automatically more secure if someone really wants to do bad stuff.). So I think the strong wording has the effect to scare users away, no matter whether the addon truely accesses your computer (Nostalgy does not).

What do I do if I install such an addon into my TB? Look at the comments on the addon download page, maybe at github issues, and verify whether there is anything that I deem suspicious. I once found an addon where users claimed that it "talks" to a suspicious home server without notifying users beforehand. I didn't install it (But also that could be done by the new addon style.)

RobertKorteweg commented 2 months ago

I still can't get the addon (4.14) to work, was at 128.1 on windows 11, even upgraded to 128.2. Addon screen shows the addon, i can configure it, can open the rules window and am able to disable/enable it. In the message window the addon suggestion does not show and pressing S does nothing. Any suggestions? Might a reinstall of TB work?

opto commented 2 months ago

which OS? Any red messages in the error console?

Sometimes this helps: close addon tab close all Nostalgy tabs. (also the updated tab) Close TB (best file->exit). All child windows need to be closed.

Wait 30 sec for all processes to finish. Restart TB

opto commented 2 months ago

just saw that it is win 11, just as mine ...

olx54 commented 2 months ago

@RobertKorteweg

For me (on MacOs Sonoma), few keys did not have the good function. For example, J not junked the messages but reply to all. I was forced to install tbkeys-lite. It shows all mapping keys and you can remove the mapping. After that, I will be enable to put my own bindings for Nostalgy.

YXgithubyx commented 2 months ago

where is everybody from?

YXgithubyx commented 2 months ago

leave a contact information

r2evans commented 2 months ago

where is everybody from?

and

leave a contact information

@YXgithubyx questions like that are usually off-topic on issues unless there is explicit need to pass errors/logs/artifacts via back-channel (perhaps for privacy concerns). Outside of that, I personally feel they are bordering on "phishing". If you use TB and Nostalgy++ and have something constructive to say for this issue (updating Nostalgy++ to TB's ever-changing API), then I welcome your contribution.

marcg1 commented 2 months ago

Here is one little thing I noticed. If I select a whole thread of e-mails and hit s, then only the first one is moved. That used to be more convenient. (Maybe I am also not clear on what "I select a whole thread" is in TB 128

Seeing the same with 4.1.14 and TB 128.2.0esr. If I select a collapsed thread and hit "S" (save), only the first message in the thread is saved. If I expand the thread, select all messages in it, and hit "S", all messages are saved.

dbergol commented 2 months ago

One more question: are there plans to get "undo" up-and-running despite the already mentioned problems with it? Desperately missing it... Best - Daniel

opto commented 2 months ago

https://bugzilla.mozilla.org/show_bug.cgi?id=1917827

discussed in length with John from TB team recently, but he needs more time

dbergol commented 2 months ago

Thanks for the update and thanks again for your continuous work!

ExpPhysU commented 2 months ago

There are a lot of changes in TB 115 (and now TB 128 which is still being totally rewritten)), because the main window has been converted to html, and many global access points to internal functions have been moved, renamed or are gone.

So the addon update for this TB update (115) is really a lot of work, so donations are very much appreciated.

Donations by Paypal: https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=6K57TUFSNMVSJ&source=url

EDIT: the news on TB 128 are ca. 142 posts further down

many thanks, Klaus

I installed the test version on TB 128.2.0esr. It works, but it block the access to the settings menu and te Add-on menu. The y are not opened, when called via the hamburger menu or via the main menu. Especially, the add-ons-management is blocked. The only be repaired by overwriting nostalgy.opto.one.xpi in the extensions folder by a backup copy of 4.1.12 Thanks for the addon

opto commented 2 months ago

@ExpPhysU : which operating system? I cannot reproduce this on Win 11 when there are no other addons.

TommyMel commented 2 months ago

I have the same problem. Every time I try to open the Addons menu or the lightning calendar nothing happens.

When trying, the console says:

javaScript error: chrome://nostalgy/content/edit_prefs.js, line 729: TypeError: evt.originalTarget is undefined

Ubuntu 24.04 Thunderbird 128.1.0esr

dochego commented 2 months ago

Using v4.1.14 on Thunderbird 128.2.2 on KDE Neon (Ubuntu 22.04), X11, without problem. @ExpPhysU and @TommyMel are you using Wayland by any chance?

cratoo commented 2 months ago

Since (auto)updating Thunderbird to 128.2.3esr on my Mac neither fast-saving (Shift-s) nor manual saving (s, then typing folder and hitting return) work anymore. Switching folder by hitting g and typing folder still works though. Ah and hiding folder pane with L also does not do anything anymore. And I'm quite sure with 128.2.2 this all still worked.

cratoo commented 2 months ago

Had to reboot today and afterwards the shortcuts work again. I'm quite sure I had restarted after the update already, but as the reboot seems to have fixed it, I wanted to post an update about this.

tommymeldgaard commented 1 month ago

@dochego - no, using X11

kohlhase commented 1 month ago

I have been running nostalgy 4.1.14 very happily on TB 128 for a couple of weeks so far, but now TB self-updated to 131 after a reboot, and now Nostalgy is "incompatible" again :-(

knoajp commented 1 month ago

Hi @opto . CC: @cwittern @h-ish . Still, donations don't work in Japan. Can I directly donate to your email address via PayPal? Or, Wise account will take less fee on transactions. 😉 https://wise.com/invite/ihpc/konosukey6

dbergol commented 1 month ago

TB self-updated to 131

As far as I can see it on the TB homepage 131 was released for testing purposes only, see https://www.thunderbird.net/en-US/thunderbird/131.0/releasenotes/

I wonder how an auto-update occured in that case - mainly to try to avoid the same problem on my computers....

sabbakix commented 1 month ago

Donated :) , thank you for your work