opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
122 stars 9 forks source link

4.0.4: 's' key command fails most of the time #221

Open PatonLewis opened 1 year ago

PatonLewis commented 1 year ago

macOS 13.5.2 (22G91) Thunderbird 115.3.1 (64-bit) Nostalgy 4.0.4

Hitting the 's' key to save a message to a folder fails most of the time. After selecting a destination folder and hitting enter, the message isn't moved and instead TB opens the message in another tab. This failure mode seems to happen about 75% of the time. The work-around for now is that after the first time it fails, you can use shift+S to successfully move the message.

opto commented 1 year ago

S ist now captured by TB top Set Star. You Need top assign another Letter in options

PatonLewis commented 1 year ago

S ist now captured by TB top Set Star. You Need top assign another Letter in options

That has not been my experience. The S key invokes Nostalgy, and I can select a destination folder, but when I hit enter the message opens instead of getting filed in the selected folder.

mcswell commented 1 year ago

My experience on Windows 11, TBird 115.3.1 is the same as PatonLewis's: S brings up the folder selector, but once you have chosen a folder, there's no way I can see to actually save the email there. Neither , , nor mousing works.

PaulPoulain commented 1 year ago

Same thing here. I'm running thunderbird 115.3.1 from Ubuntu, French.

Olifair commented 1 year ago

I think it really depends on the language you are using TB in : in my TB 115 running on a French Ubuntu, S did not work, however switching to V did make moving the message work. You might want to add the language to your post, so we can get an overview

PaulPoulain commented 1 year ago

I'm running Ubuntu in French too. My key is not S, it's E (for years). close to the "R" for "mark as read". So I usually do R - E > folder (and most often R - > SHIFT-E for immediate sorting.

mcswell commented 1 year ago

I'm using English. And I'll say it again, in case I wasn't clear the first time: The problem does NOT appear to be with the S key, which works fine--I get to select a folder. Rather, the problem is with the Enter key, which T-Bird now co-opts for the "open this msg in a different tab." So despite successfully selecting a folder, the msg doesn't get saved to that folder.

I don't see a way to remap the Enter key in Nostalgy.

And yes, I tried changing the S key, but the same thing happens when I hit Enter.

(edited because github apparently deletes things that have less than and greater than symbols, as if they were HTML or XML tags)

mcswell commented 1 year ago

TB115 (test version) installed today. It says that using an up/down key before hitting Enter will make it save to the intended location, rather than opening it in a new tab. I confirm that this works on my Windows 11, TB 115.3.2. Strange work-around, but better than before!

PaulPoulain commented 1 year ago

thx mcswel. I missed that you had to hit up AND down in order for the workaround to work. I confirm that's the case.

it work

adamkerz commented 1 year ago

Just UP seems to work for me.

mcswell commented 1 year ago

Just UP seems to work for me.

Probably, but if I hit UP then I think I need to hit DOWN to get back to where I was.

adamkerz commented 1 year ago

Ah, yes, true. I usually type enough letters to only have one suggestion, so just UP works then. But I'm used to using the arrows to select the right one when there are multiple items, so that didn't occur to me.

hkclark commented 1 year ago

I'm getting the same behavior... if I don't use the Up and possibly Down arrow keys and just hit Enter then it opens the email and doesn't move the email.

Has anyone figured out if it's possible to open an email in a tab (so not just the Message Pane) and use Nostalgy to move or copy the email? I have to close the email and use my arrow keys to move away from the email and back to it before I can it my "move" hotkey and have it do a move... I really miss being able to file stuff right from reading the message vs all those extra keystrokes.

PatonLewis commented 1 year ago

Version 4.0.5 fixed this issue! Yay!

mcswell commented 1 year ago

Version 4.0.5 fixed this issue! Yay! Outstanding! I just downloaded and installed the .xpi file, and I confirm it works. Well done!

vysmaty commented 1 year ago

Hi. Next to this extension I use "Tagger". I type CTRL+T and start typing the tag name to add. Unfortunately the keys (e.g. S) assigned to Nostalgy cannot be typed. It immediately switches to Nostalgy. I don't have this problem with tbkeys-lite keys. Would it not be possible to restrict it to responding only outside of other text boxes? Thanks.