opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
122 stars 9 forks source link

4.0.5: Cannot use Nostalgy when email is "open" in a tab and takes extra keystrokes once I close it #224

Closed hkclark closed 1 year ago

hkclark commented 1 year ago

I normally keep the "Messages Pane" (F8) closed and hit Enter on each message to open it and read it using the full size of the overall Thunderbird window. Before TB 115 I could use Nostalgy to move the message while the message was open (it would close the message and do the move, returning me to whatever folder I was in when I opened it). With TB 155 and any of the 4.0.X Nostalgy++ versions, I see the Nostalgy icon (two boxes and the curved arrow) down in the lower right of the status bar (and if I hover over the icon, it mention the Nostalgy keyboard shortcuts I have configured), but none of the shortcuts do anything and it never shows "[+ Shift => SomeFolderHere]".

To move the message I have to: 1) Close the email (e.g., Ctrl+W) and return back to whatever folder I opened the message from

I have tried disabling all other Addons and it doesn't seem to change the behavior I'm getting. I have noticed this across all of the TB 115.X.X and Nostalgy 4.0.X versions, but currently I'm on TB 115.3.2 and Nostalgy 4.0.5.

Thank you very much!

opto commented 1 year ago

yes, operation in message pane/window has not been reactivated yet, will follow

hkclark commented 1 year ago

@opto OK, great. Thank you for letting me know it's on the list!

opto commented 1 year ago

it works in the 3pane with message always open .I didn t try closed then open with F8. Maybe the Statusbar then has items with other id than what we use for insertbefore, and Part gets left off or are not activated.

Also, pure messagewindow is on the way but not Finished yet. there are just so many functions that disappeared and which are now in a different class with a totally different Name.

like the function to Focus the next message after delete or move. obviously tb still does that, but it is a good example for something now hidden somewhere. no big Deal, but there are millions disappeared functions.

opto commented 1 year ago

ok, so when we are in the mainwindow, but not in mail:3pane, but in a tab with type messageDisplay ... then we need the Nostalgy commands.

so yes, this will be coming

opto commented 1 year ago

this is working now and a test version will come later today

opto commented 1 year ago

https://github.com/opto/nostalgy-xpi/releases/tag/v4.0.6

hkclark commented 1 year ago

@opto Initial testing on my end looks great! Thank you! I'll leave this open for another day to maybe get input from others, but I'll make a note to close it tomorrow (in ~24 hours) if nobody has uncovered any issues. Thanks again.

hkclark commented 1 year ago

@opto I have not noticed any issues at all with this and since we haven't heard of issues with anyone else, let's close this. Great work fixing this!!