Nostalgy breaks close email with ESC

opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.

Other

122 stars 9 forks source link

Nostalgy breaks close email with ESC #235

Open Izwbusr opened 1 year ago

Izwbusr commented 1 year ago

Hi:

When Nostalgy is running, ESC no longer closes email. Please fix.

bbailleux commented 1 year ago

When Nostalgy is running, ESC no longer closes email..

Today, I have been delighted to see that Nostalgy++ (version 4.1.2) is now available again in my Linux / Thunderbird 115.4.1

But I face the same annoying behaviour: the <Esc> key no longer allows to close a message window. By the way, the <Alt>F4 or the <Ctrl>F4 sequences are still working (Edit: as well as <Ctrl>w).

Furthermore, the <Esc> key is no longer effective when trying to close a search field after opening it with <Ctrl>F. There is maybe some other uses of <Esc> that are disabled as well…

I noticed that the 4.1. version of Nostalgy++ contains the "in quickfilter, esc is handled normally. So use ctrl shift k to get there, use quickfilter, then empty and/or close with esc" feature.

I guess the <Esc> event is maybe caught too aggressively?

(BTW, the last available version available here is 4.1.1, thus I do not understand why I am currently using the 4.1.2 version, after today's auto update)

r2evans commented 1 year ago

I don't know if it is the same thing, but I find that using Q to quick-filter on the sender, then using Esc to return to the full view breaks the use of quickfilter.

press Q to quick filter on the sender
when done, Esc did nothing, so I put the focus on the text box (with the email being quick-filtered), hit Esc
Q does nothing now
switch to either (a) another TB tab, or (b) another app/window (not at all TB), then back to TB's Inbox
Q works again in the same away

TB-115.4.2, nostalgy++ 4.1.2

benlundmaine commented 1 year ago

I am seeing the same thing. It only happens when one moves away from the open email to another window, and then back. If one hits escape right away, without moving to another window, the behavior is as expected. If the addon is disabled, there is no unexpected behavior. Thanks for all of the work to get it this far.

Izwbusr commented 10 months ago

Any update on this? It is really annoying. Can you give us the options to choose if we want to surrender the ESC key to Nostalgy?

Izwbusr commented 8 months ago

Hello,

I just wanted to highlight this issue again. If it can be fixed, it would be very appreciated. I am a long-time user and have donated to the effort (thanks for your work!). Closing emails with ESC is essential, as it is the expected behavior in many applications. It would be great if this could be fixed.

pierredGitHub commented 8 months ago

I second Izwbusr. Esc is essential. Works everywhere else in TB. Can we have an update please? It’s been almost 5 months and no feedback about this issue.