opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
117 stars 9 forks source link

TB 115.5.0, Linux, Nostalgy 4.1.2: Shortcuts don't work anymore #249

Open k11i opened 8 months ago

k11i commented 8 months ago

Hello! After my current update to

TB 115.5.0 Debian stable Nostalgy 4.1.2

shortcuts don't work anymore.

s: sets star to message shift-s: No effect c: opens requester to mark messages as read g: no effect

I even tried to set save to CTRL-SHIFT-S but that does not work either.

Is there a suggested workaround? Are there any "free letters" to configure the shortcuts to, so that Thunderbird will not usurp them?

Would it be possible to add the functions also as a fallback to the right click menu of the message list pane?

opto commented 8 months ago

do you have restrict commands to email tabs set?

Other than that, it seems that TB again captures the letters before we can interpret them. It seems they made the latest workaround inoperable.

In options, you can set other letters. You have t try beforehand which don't have a TB standard action attached. That is dependent on TB language.

Right click menu is a good idea as enhancement

k11i commented 8 months ago

Hello Klaus!

Hmmm, I thought I answered this yesterday. ;-)

do you have restrict commands to email tabs set?

Yes. I tried to switch it of but no change. (I haven't restarted Thunderbird after switching this off, do I have to restart Thunderbird for this to have any effect?)

Other than that, it seems that TB again captures the letters before we can interpret them. It seems they made the latest workaround inoperable.

Is there any way I can provide you with more information or logs to find the cause for this?

In options, you can set other letters. You have t try beforehand which don't have a TB standard action attached. That is dependent on TB language.

I'm using "English (GB)" as the language in settings. I haven't yet found a letter that isn't taken. ;-) (According to https://support.mozilla.org/en-US/kb/keyboard-shortcuts-thunderbird or https://support.mozilla.org/en-US/kb/keyboard-shortcuts-thunderbird)

Right click menu is a good idea as enhancement

:+1:

Thx&greetings!

ChristianNext commented 8 months ago

The Add-ons comment by FX on Nov. 10, 2023 fixed it for me.

I solved my problem via the Thunderbird configuration editor and passing the following 2 parameters to False:

  • accessibility.browsewithcaret_shortcut.enabled
  • ui.key.textcontrol.prefer_native_key_bindings_over_builtin_shortcut_key_definitions
k11i commented 8 months ago

The Add-ons comment by FX on Nov. 10, 2023 fixed it for me.

I solved my problem via the Thunderbird configuration editor and passing the following 2 parameters to False:

  • accessibility.browsewithcaret_shortcut.enabled
  • ui.key.textcontrol.prefer_native_key_bindings_over_builtin_shortcut_key_definitions

Sadly this does not work here. Set both configuration vars to False but even after Thunderbird restart S still toggles the "Star" and Shift-S does nothing. :-(

ChristianNext commented 8 months ago

Hi k11i, strangely sometimes it does not work, then after TB restart it works again.

I also experience inconsistent AddOn behaviour with cardbook, https://cardbook.icu/forum/forums/topic/email-context-menu-missing/

Could this inconsistency be related to 115?

k11i commented 8 months ago

I just found this article:

https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox

and accessed the page as described there.

Interestingly there I found the following message:

The following extensions do not have shortcuts:

  • Manage Emails/ Nostalgy++

The other extension I have installed (Thunderbird Conversations) is shown to have a shortcut and this also works. That is strange. So this does not seem to be a general problem.

Screenshot_2023-12-11_23-49-31

opto commented 7 months ago

I think I can easily add such shortcuts, but they will be multiletter (by Thunderbird design). So for ease of use, it would still be better to test for single letters that do not do anything in Thunderbird and set the standard commands to these letters. That depends on locale, in German, for example, I could use V and X, but not S.

Also, it might be worth to keep Thunderbird's S for star. It is just history from very long ago to use S, and even a misnomer, because it is not a S(ave) but a M(ove)

opto commented 7 months ago

To use the build in commands: I can set them by operating system. I do not use Linux, do you have any proposals that are good for you?

One probably would want a modifier + 1 letter, or two letters that are next to each other. The user can adjust those in general addon settings to other values.

Syntax: Key combinations must consist of 2 or 3 keys:

modifier (mandatory, except for function keys). This can be any of: "Ctrl", "Alt", "Command", or "MacCtrl". secondary modifier (optional). If supplied, this must be either "Shift" or (for Firefox ≥ 63) any one of "Ctrl", "Alt", "Command", or "MacCtrl". Must not be the modifier already used as the main modifier. key (mandatory). This can be any one of: the letters A – Z the numbers 0 – 9 the function keys F1 – F12 Comma, Period, Home, End, PageUp, PageDown, Space, Insert, Delete, Up, Down, Left, Right

ChristianNext commented 7 months ago

One probably would want a modifier + 1 letter

I strongly prefer a single key, because I use it hundreds of times every day to manage email.

opto commented 7 months ago

most of them work as Alt+old letter, coming soon

ChristianNext commented 7 months ago

most of them work as Alt+old letter, coming soon Why?? Please leave these most often used shortcuts as single letters, don't make us do finger acrobatics a few hundred times a day..... The current version 4.1.2 seems to work (most of the time).

opto commented 7 months ago

you will have both ... the old, which you can change in the settings, and the new, which you can change in the general addon settings

It (even S) also works fine here on Win 11, but for those where it does not work and nobody knows why, there will be a second way to do this.

k11i commented 7 months ago

Hi! Is there a way to supply you with more information like logfiles or something to find out, why those keys are not working? I tried to set the shortkey for safe in the preference window CTRL+SHIFT+S but this didn't work either. BTW: There are some Radio-Buttons and a text field below the shortcuts in the preference window. I scanned the documentation but cannot find the function for this. What do I do there? Screenshot_2024-01-06_00-03-41

opto commented 7 months ago

1) in the bottom, you can define new letters to go/save etc into your own defined folders. 2) If S does not work, I do not expect any combinations with S to work 3) On german keyboard, I think V and X were ok to use 4) test yourself: goto TB main window, press buttons, find those which do not do anything. Enter them instead of S into the table

opto commented 7 months ago

and in my new version, alt-S, alt-shift-s and others do work, for example. Version not yet uploaded ...

opto commented 7 months ago

beware ... some letters do delete emails etc.

try in a folder where you have unimportant messages only. Try also with a message selected in the message list.

k11i commented 7 months ago

I got an US-Keyboard, Debian Linux and currently 115.6.0.

I now tried to set the comma (","), the semicolon (";") and SHIFT-colon ("shift :" which is the same key as the semicolon together with shift) for the "Save message" function. But none of those shortcuts do anything.

According to this article here: those keys are not bound at another function.

k11i commented 7 months ago

I get a lot of those in the error console, does this help? Screenshot_2024-01-06_00-49-55

But those messages are not timed in sync to my tries to press the configures shortcuts.

mdonz commented 7 months ago

FWIW, similarly to @k11i, I am running Ubuntu Linux and TB 115.6.0 and I see lots of "suggest: no dbview" messages with exactly the same block of details from

NostalgySuggest chrome://nostalgy/content/nostalgy.js:785 .. to ... recvAPICall resource://gre/modules/ExtensionParent.sys.mjs:1141

without doing anything "special" at the time.

k11i commented 7 months ago

Hello @mdonz!

without doing anything "special" at the time.

Those "suggest: no dbview" entries in the console happen in pairs every time my mouse pointer leaves the window and the Thunderbird main window gets deactivated and another window gets the focus ("Focus follows mouse feature").

opto commented 7 months ago

that is correct ... and nevertheless, sometimes, when needed, the variable remembering the view looses its content. I solved that in the most recent version by always looking up the view from TBcode.

After that change, k11i is correct, this happens then only for tabs which have no message view (=gDBView)

I think I will upload here ca. tomorrow.

pierredGitHub commented 7 months ago

I can't wait for the version that will allow Alt-S, Alt-C, ... to work. Any news? Thanks.

pierredGitHub commented 7 months ago

Another week has passed. It's now been 2 weeks since Karl (opto) made the comment "I think I will upload here ca. tomorrow.". Karl, can we get an update on the version that will allow us to use the Alt key in combination with letter keys? Thanks.

opto commented 6 months ago

please try this, it uses the new webextension shortcuts in addition to old Nostalgy one letter shortcuts: https://github.com/opto/nostalgy-xpi/releases/tag/v4.1.3

pierredGitHub commented 6 months ago

I replied directly to Klaus so repeating here.

Thank you so much for this new version. I can report I have limited success with it. I tried to define s, c, and g but they did not work.

So I tried to define Alt-S, Alt-C, and Alt-G. Only Alt-S and Alt-C worked (that's progress) but Alt-G did not as it instead invoked the Go menu from the menubar (I have the menubar always showing).

So I tried to define Shift-Ctrl-G but that did nothing. So I am almost there with Save and Copy, but I still need Go to folder.

Also please note that the Nostalgy Preferences window is way too high for my laptop (1920 x 1080 with 150% magnification). If I did not have an external display configured above the laptop screen, I would not be able to move the Preferences window up to be able to uncover the OK button. The window has no scrolling bars so the OK button can't be normally seen. And if I move the bottom edge of the window up, it hides the OK button as the button does not move up in the window with the bottom edge. So there is something wrong with this window's attributes. And it's not resizable to make it full screen. I hope I made myself understandable.

Looking forward to your next version where the Go to folder can be made to work.

opto commented 6 months ago

you need to find letter combinations that are free by trial and error. These letter combinations are localised, so different for different languages. So please try alt-A till alt-Z (or alt-9) or any combination of alt, shift, ctrl and letters/numbers. When you find one that does "nothing" in a normal TB, you can change alt-G to what you found, that should work. extra menu-addons-cog symbol- change shortcuts (last menu entry), there you can change the double/tripleletter combinations)

mdonz commented 6 months ago

FWIW, there seem to be plenty of options to define a Go command shortcut via "Manage Extension Shortcuts" on my English based Ubuntu desktop running TB 115.7.0. And it is very easy to set them up or change, no TB restart required as it looks like. I tried for example ALT+I, ALT+J, ALT+X, all available in my set up here.

pierredGitHub commented 6 months ago

I finally was able to define a shortcut for "Go to folder": Alt-J, without the use of the "Manage Extension Shortcuts" add-on. Why Shift-Control-G or Alt-Shift-Control-G or any other combination with G did not work, I do not know, and I find it weird. But at least I now have a shortcut to go to a folder.

ChristianNext commented 6 months ago

v 4.1.0 does not consistently enable single letter shortcuts for me. "S" often stars the messages instead. This happens almost every time I start TB. Workaround: After disabling and enabling nostalgy 4.1.0, then the single keys S etc. do work. TB 115.6.0, Ubuntu 23.10

pierredGitHub commented 6 months ago

The trick of disabling and re-enabling Nostalgy, it worked for me with 4.2.0, but only sometimes. But more often than not, "S" would star or unstar the email. As mentioned above, I ended up defining Alt-S, Alt-C, and Alt-G and that seems to now work reliably, only for 24-48h so far.

oehm-smith commented 5 months ago

I also had problem of Keys suddenly not working - TB Version 115.8.0 and I'm not sure if this update was installed just before the problem started happening. I assume so.

I resolved it by changing the keys to what they are / were.

ExpPhysU commented 5 months ago

Same with latest versions of Thunderbird and Nostalgy++ on Windows 11, S is hijacked by Thunderbirds, and since I never use the stars, tis is annoying. S is always set to Star after restart, disabling and reinabling Nostalgy helps, Maybe there coud be a shurtcut key to just do that?

mdonz commented 5 months ago

"S" is used by Thunderbird hence most users seem to have gone to define a different key to save in the Nostalgy Preferences. I chose "R" (and "Shift R" to "save as suggested") and this works reliable here. Just forget about S and get used to a different key.