opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
117 stars 9 forks source link

ALT-G : go back from folder not working anymore #254

Open Olifair opened 6 months ago

Olifair commented 6 months ago

The shortcut "ALT-G" with the action "go back from folder" is not working anymore, at least on my system (TB 115.7.0 Nostalgy++ 4.1.4) When tapping ALT-G I get the same result as just tapping G : the Nostalgy input field at the bottom opens and waits for typing in a folder. When I chose a different ALT-letter combination for the "go back from folder" action (e.g. ALT-Q), then just nothing happens. When I chose only "Q" then also nothing happens. So final conclusion after tests : the "go back from folder" action does not work anymore.

I think that this problem is not new in the 4.1.4 version but has already existed before

Cheers

Oliver

mdonz commented 6 months ago

I have defined "Ctrl-G" as shortcut to go back here (TB115.7, Nostalgy 4.1.4 on Ubuntu) and that works for me. Michael

opto commented 6 months ago

here (Win 11, German): G works, alt-G not, but the new ctrl-alt-G

blerner commented 6 months ago

I wonder if this is similar to #253 and the release comment on 4.1.3,

this in addition uses webextention commands. So S is also usable as alt-S

Perhaps the handling of Alt+... hotkeys is more generally getting conflated with the non-Alt+... versions of the keys? @Olifair does Alt+G work for you in 4.1.1, the way Alt+I works for me in v4.1.1 but not above?

Olifair commented 6 months ago

@blerner no, that was the whole problem in the first place, ALT-G is not working. I'm using "Q" now and that is working well :-) I have tested this on 4.1.4, but I think i had had the problem for a while, so I guess probably also with 4.1.1

garnajee commented 4 months ago

I would like to add that any of ALT+... isn't working But with AltGr+... it works. nostalgy++ v4.1.4 thunderbird v115.9.0

opto commented 4 months ago

I think TB uses a new way to grab the keypressed which I found no way to override for some letter combinations. Therefore, there are the new key combinations on the webextension side. Even there, you need to test which letter combinations are free to be used. But once found, those should be guaranteed to work (?) by the new webextention support of TB. If those don't work, please let me know.

opto commented 4 months ago

actually, the old style alt-G does not work because I erroneously set alt-G in the new commands as replacement for G.

On my German PC, the new shift-alt-G for go back does not work becaue it seems to be in use by TB, but shift-alt-L works for go back.

But if I set the new alt-G to something else, the old alt-G for go back is still grabbed by TB and it does not go back. So it seems at the moment, go back needs to used with a new command

mdonz commented 4 months ago

FWIW, I set my "Go Back" to be Ctrl-g in the Nostalgy Preferences only (no shortcuts defined at all yet for Nostalgy in web extensions/Extension Shortcuts to avoid confusion while testing shortcuts). That's by now TB ver. 115.9.0, Ubuntu, English, Nostalgy 4.1.5.

opto commented 4 months ago

thanks, I can confirm this works on German Win 11 as well.

Olifair commented 4 months ago

I'm using just "Q" for the "go back from folder" option, and it's working well (French windows 11 system with a German keyboard). I'm so used to it by not, that probably I would keep it, even if ALT-G would work again ;-)