search

optonaut / ActiveLabel.swift

UILabel drop-in replacement supporting Hashtags (#), Mentions (@) and URLs (http://) written in Swift
MIT License
4.47k stars 686 forks source link

Mention and hashtag regex values should be exposed as properties #157

Closed diegoperini closed 5 years ago

diegoperini commented 7 years ago

Right now we need to unlock the pod to be able to edit.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

diegoperini commented 5 years ago

I hope this won't be closed.

maziyarpanahi commented 5 years ago

Hi @diegoperini, you can always reopen a closed issue or open a new one. The bot detects stale issues which haven't had any activity for the past 6 months. This means the issue or request won't be solved or developed by the maintainers. Unfortunately, whether it is open or closed won't change that result. PS: why do you need to change the regex for mention and hashtag when you can have your own custom types? https://github.com/optonaut/ActiveLabel.swift#custom-types

diegoperini commented 5 years ago

Because semantically my custom regex rules stil capture mentions and hashtags but with additional improvements for Turkish language. Writing custom types felt overkill and redundant.

On Mon, Nov 26, 2018, 17:54 Maziyar Panahi <notifications@github.com wrote:

Hi @diegoperini https://github.com/diegoperini, you can always reopen a closed issue or open a new one. The bot detects stale issues which haven't had any activity for the past 6 months. This means the issue or request won't be solved or developed by the maintainers. Unfortunately, whether it is open or closed won't change that result. PS: why do you need to change the regex for mention and hashtag when you can have your own custom types? https://github.com/optonaut/ActiveLabel.swift#custom-types

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/optonaut/ActiveLabel.swift/issues/157#issuecomment-441666395, or mute the thread https://github.com/notifications/unsubscribe-auth/ABT5sPzNmqQDtCnGJW9Gr61tEy_kAdlpks5uzACZgaJpZM4L_T7W .

maziyarpanahi commented 5 years ago

I understand, but that is why we have custom types since there is no right regex pattern for all the use cases. Now I understand the issue clearly, this won't be fixed since we have custom types so you can turn off the .mention .url .hashtag if you don't need them and move on with your improved custom types which could share some similarities. Custome types are the best practice and flexible when it comes to these types of situations. Feel free to open a new issue if you have any question in custom types.

Best,