optonaut / ActiveLabel.swift

UILabel drop-in replacement supporting Hashtags (#), Mentions (@) and URLs (http://) written in Swift
MIT License
4.47k stars 686 forks source link

Swift 4 support to this library #216

Closed shubhamKhelfie closed 6 years ago

shubhamKhelfie commented 6 years ago

when i was trying to pod this in library in xcode 9.0.1, in the pod directory it shows 14 errors.

ZacharyKhan commented 6 years ago

According to issue #197 it seems to just be the pod spec that needs updating. A PR fixing this has been submitted as #212 but @optonaut has to accept it.

ThoseGuysInTown commented 6 years ago

Any progress on this? The library no long works for me after updating to swift 4

pariz commented 6 years ago

@ThoseGuysInTown same for me, compile it in swift 3.2 for now

ZacharyKhan commented 6 years ago

Seems #212 has been merged but I’m still running into issues of Swift 4 syntax with the pod, even after running pod update

JunaidVizz commented 6 years ago

not working in swift 4 :(

ZacharyKhan commented 6 years ago

@JunaidVizz I’m running the newest version on Swift 4, iOS 11.2 & Xcode 9.2 without issues. Have you run pod update?

If so, what exactly is the error?

JunaidVizz commented 6 years ago

yes i did run pod update command.. it gives 15 syntax errors including @IBinspectable and string.characters etc

On Fri, Dec 8, 2017 at 5:29 PM, Zachary Khan notifications@github.com wrote:

@JunaidVizz https://github.com/junaidvizz I’m running the newest version (1.6.0) on Swift 4 without issues. Have you run pod update?

If so, what exactly is the error?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/optonaut/ActiveLabel.swift/issues/216#issuecomment-350252086, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae-ysqKmmL07FouX7F9dO0LFneMGZRR0ks5s-SvEgaJpZM4QPy4V .

JunaidVizz commented 6 years ago

now i did it my self. :) no need to use pod now..

On Fri, Dec 8, 2017 at 6:39 PM, Junaid Vizz junaidvizz@gmail.com wrote:

yes i did run pod update command.. it gives 15 syntax errors including @IBinspectable and string.characters etc

On Fri, Dec 8, 2017 at 5:29 PM, Zachary Khan notifications@github.com wrote:

@JunaidVizz https://github.com/junaidvizz I’m running the newest version (1.6.0) on Swift 4 without issues. Have you run pod update?

If so, what exactly is the error?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/optonaut/ActiveLabel.swift/issues/216#issuecomment-350252086, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae-ysqKmmL07FouX7F9dO0LFneMGZRR0ks5s-SvEgaJpZM4QPy4V .

ZacharyKhan commented 6 years ago

The string.characters warning you're seeing is a deprecation warning letting you know that particular function or property will be deprecated in an upcoming release.

This issue has been fixed in PR #212. As soon as @optonaut updates the pod spec and pushes to the cocoa pods trunk you will see the update reflected in terminal when you run pod update. If you need to, you can always add a flag to your .podfile for the ActiveLabel pod and pull directly from the master branch from the github URL.

  pod 'ActiveLabel', :git => 'https://github.com/optonaut/ActiveLabel.swift', :branch => 'master'

Are there any further issues that are keeping you from successfully compiling your project?

@optonaut can you please close this issue or add me as a contributor so I can help clean up the issues and PR?

heiyeliuying commented 6 years ago

not working in swift 4

maziyarpanahi commented 6 years ago

Version 0.8.1 is now available on CocoaPods: https://cocoapods.org/pods/ActiveLabel