search

optonaut / ActiveLabel.swift

UILabel drop-in replacement supporting Hashtags (#), Mentions (@) and URLs (http://) written in Swift
MIT License
4.47k stars 686 forks source link

Autoshrink does not work when using ActiveLabel #33

Closed ghost closed 7 years ago

ghost commented 8 years ago

I am trying to make the label autoshrink by setting in the interface builder: Autoshrink: Minimum Font Size 9, but it has no effect. I want to make the label gets smaller to make the whole string fit inside the UILabel´s frame. Any fixes for this?

polqf commented 8 years ago

At the moment, ActiveLabel does not have support for this

ghost commented 8 years ago

Well, @rishi420 already forked the repo and made a fix for it: https://github.com/rishi420/ActiveLabel.swift

Maybe you could add it the the original package?

polqf commented 8 years ago

Of course. I did not understand why he did it. Now I get it I'll do a PR to this repo when I can

ghost commented 8 years ago

Awesome, could you send me a comment when it's done, ye?

ghost commented 8 years ago

When will you do this?

polqf commented 8 years ago

I work on ActiveLabel on my spare time, and I currently have this #40 PR open, which is a big refactor, and that's what I work on when I can. When I finish, I'll work on this.

If you are in a hurry, feel free to open a PR 😊

ghost commented 8 years ago

Ohh ok, i understand! :)

This guys already open a PR about it i think: https://github.com/rishi420/ActiveLabel.swift

I quote what he(rishi420) wrote to me: "I've shared this question link to ActiveLabel collaborators, made a pull request to their repository. They could merge my commit or they will refactor code to improve for these features."

chrisdhaan commented 8 years ago

Did this ever get resolved? I can't tell if it was supposed to be included in #40 PR or not.

polqf commented 7 years ago

Closing due to inactivity