optuna / kurobako-py

A Python library to help implement kurobako's solvers and problems
MIT License
9 stars 7 forks source link

Use optuna.Study.ask/tell instead of BaseStorage.set_trial_values etc. #16

Closed contramundum53 closed 2 years ago

contramundum53 commented 2 years ago

Motivation

OptunaSolver currently accesses self._study._storage.set_trial_values etc. in tell(), which is private. The function set_trial_values is changed to set_trial_state_and_values in newer versions of Optuna, and those lines are also affected. We propose to use self._study.tell() instead of directly accessing self._study._storage.set_trial_values, and also make corresponding changes to ask().

Description