Fix bugs in kurobako/solver/optuna.py

optuna / kurobako-py

A Python library to help implement kurobako's solvers and problems

MIT License

9 stars 7 forks source link

Fix bugs in kurobako/solver/optuna.py #19

Closed contramundum53 closed 2 years ago

contramundum53 commented 2 years ago

Several bugs were present in kurobako/solver/optuna.py that resulted in errors when used with nontrivial pruners.

trial.last_step is undefined when trial is not a FrozenTrial.
self._study._log_completed_trial requries a FrozenTrial, but a Trial is passed
Logs for pruning are invisible

These bugs are fixed in this PR.

HideakiImamura commented 2 years ago

I privately discuss above with @contramundum53 and @sile. As a result, we have decided to generate a log in our own format for the completed trials in this PR. The reason are

to be in the same format as pruned trials, and
note to use _log_completed_trial, which is a private method of optuna.

contramundum53 commented 2 years ago

We reverted changes about _optuna_logger and made them a separate issue (#20).