Partially replace recoil with react-query

porink0424 commented 7 months ago

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

[x] I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Partially replaced recoil states with react-query states for:

Hypaerparameter Importance
Graph[Rank, Contour, ParallelCoordinate, Slice]
~~studySummary~~ ← studySummary and studyDetail are intertwined in implementations, and it is hard for now to replace recoil states regarding only studySummary. So I once abandoned them for now.

Careful checks are needed to ensure that cache update timing is as expected 🙏

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d30ed93) 69.81% compared to head (3880129) 69.71%. Report is 5 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #801 +/- ## ========================================== - Coverage 69.81% 69.71% -0.11% ========================================== Files 35 35 Lines 2369 2364 -5 ========================================== - Hits 1654 1648 -6 - Misses 715 716 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

c-bata commented 7 months ago

Is this PR ready for review?

porink0424 commented 7 months ago

Is this PR ready for review?

Yes, I forgot to put it in the ready state 🙇

optuna / optuna-dashboard