Drop inf & -inf from TrialValueNumber

optuna / optuna-dashboard

Real-time Web Dashboard for Optuna.

https://optuna-dashboard.readthedocs.io/en/latest/

Other

503 stars 83 forks source link

Drop inf & -inf from TrialValueNumber #808

Closed porink0424 closed 6 months ago

porink0424 commented 6 months ago

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

[x] I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Drop inf & -inf from TrialValueNumber

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.53%. Comparing base (88be4cb) to head (b976fa1). Report is 44 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #808 +/- ## ========================================== - Coverage 69.71% 69.53% -0.18% ========================================== Files 35 35 Lines 2364 2367 +3 ========================================== - Hits 1648 1646 -2 - Misses 716 721 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nabenabe0928 commented 6 months ago

It seems the following files need the changes:

[x] optuna_dashboard/_serializer.py
[x] optuna_dashboard/ts/components/GraphContour.tsx
[x] optuna_dashboard/ts/components/GraphIntermediateValues.tsx
[x] optuna_dashboard/ts/components/GraphParetoFront.tsx
[x] optuna_dashboard/ts/components/GraphRank.tsx
[x] optuna_dashboard/ts/components/TrialFormWidgets.tsx
[x] optuna_dashboard/ts/components/TrialTable.tsx
[x] optuna_dashboard/ts/dominatedTrials.ts
[x] optuna_dashboard/ts/trialFilter.ts
[x] optuna_dashboard/ts/types/index.d.ts
[ ] standalone_app/src/components/PlotHistory.tsx
[ ] standalone_app/src/components/PlotImportance.tsx
[ ] standalone_app/src/components/PlotIntermediateValues.tsx
[ ] standalone_app/src/components/TrialTable.tsx
[ ] standalone_app/src/sqlite3.ts
[ ] standalone_app/src/types/index.d.ts

c-bata commented 6 months ago

@nabenabe0928 Thank you for your review! The codebases for the standalone app (which is internally used from the VS Code extension) are separated with the codebases for the Python package. So could you only check the files under the standalone_app directory?