optuna / optuna-dashboard

Real-time Web Dashboard for Optuna.
https://optuna-dashboard.readthedocs.io/en/latest/
Other
503 stars 83 forks source link

Replace StudySummary to FrozenStudy in serializing #809

Closed keisuke-umezawa closed 6 months ago

keisuke-umezawa commented 6 months ago

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

Reference Issues/PRs

To make a follow-up PR for https://github.com/optuna/optuna-dashboard/pull/783

What does this implement/fix? Explain your changes.

In optuna v3, to get attribute of a study, FrozenStudy was introduced and it is performance efficient. As we deprecated optuna v2, we can use it now instead of StudySummary.

codecov[bot] commented 6 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ead77a9) 69.53% compared to head (9170b88) 69.53%. Report is 12 commits behind head on main.

:exclamation: Current head 9170b88 differs from pull request most recent head 8f39413. Consider uploading reports for the commit 8f39413 to get more accurate results

Files Patch % Lines
optuna_dashboard/_app.py 75.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #809 +/- ## ========================================== - Coverage 69.53% 69.53% -0.01% ========================================== Files 35 35 Lines 2370 2360 -10 ========================================== - Hits 1648 1641 -7 + Misses 722 719 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nabenabe0928 commented 6 months ago

@gen740 @c-bata Could you review this PR?