optuna / optuna-dashboard

Real-time Web Dashboard for Optuna.
https://optuna-dashboard.readthedocs.io/en/latest/
Other
503 stars 83 forks source link

Virtualize trials list #810

Closed y0z closed 5 months ago

y0z commented 6 months ago

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

What does this implement/fix? Explain your changes.

It is known that the Optuna dashboard seriously slows down to show the list of trials when the number of trials is too large (e.g., N > 100,000). This PR virtualizes the list of trials to accelerate rendering in the dashboard/studies/:id/trials page.

nabenabe0928 commented 6 months ago

@keisuke-umezawa Could you review this PR?

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.60%. Comparing base (f8650a8) to head (e82d3b9). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #810 +/- ## ======================================= Coverage 69.60% 69.60% ======================================= Files 35 35 Lines 2375 2375 ======================================= Hits 1653 1653 Misses 722 722 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

y0z commented 6 months ago

Thank you for your comment. I've fixed this.

Also, I found a minor difference of UI. Could you fix it?

image
y0z commented 5 months ago

LGTM! It also worked in my env. Could you resolve conflicts?

The conflicts have been resolved :)