Fix best trial history for pruned trials

optuna / optuna-dashboard

Real-time Web Dashboard for Optuna.

Other

477 stars 83 forks source link

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

[x] I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Pruned trials are incorrectly included in the best trials. For example, the second trial in the study below becomes the best.

import optuna

study = optuna.create_study(study_name="tmp", storage="sqlite:///tmp.db")
trial = study.ask()
study.tell(trial, 1)
trial = study.ask()
trial.report(step=0, value=0)
study.tell(trial, state=optuna.trial.TrialState.PRUNED)

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.51%. Comparing base (978695b) to head (4f76b8a). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #852 +/- ## ======================================= Coverage 69.51% 69.51% ======================================= Files 35 35 Lines 2375 2375 ======================================= Hits 1651 1651 Misses 724 724 ```

optuna / optuna-dashboard