optuna / optuna-dashboard

Real-time Web Dashboard for Optuna.
https://optuna-dashboard.readthedocs.io/en/latest/
Other
477 stars 83 forks source link

Save setting values into Local Storage #856

Closed porink0424 closed 3 months ago

porink0424 commented 3 months ago

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.51%. Comparing base (978695b) to head (26fe670). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #856 +/- ## ======================================= Coverage 69.51% 69.51% ======================================= Files 35 35 Lines 2375 2375 ======================================= Hits 1651 1651 Misses 724 724 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

porink0424 commented 3 months ago

I tried to support const [colorMode, setColorMode] = useState<"light" | "dark">("light") as well, but since useMediaQuery is used for checking user preference, I did not support here for this time.

c-bata commented 3 months ago

@keisuke-umezawa Could you review this PR?