This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
[x] I agree this patch may be ported to Goptuna by other Goptuna contributors.
Reference Issues/PRs
Follow up PR of #860
What does this implement/fix? Explain your changes.
Improved the parsing error handling in JournalStorage:
The implementation was designed so that even a single error line would cause the entire system to crash, but error lines can now be pushed into errors variables to prevent it.
Added tests for JournalStorage:
Checking studies including Infinity, -Infinity, NaN.
Checking if the system does not crash even when lines that cannot be parsed are included in the file.
Contributor License Agreement
This repository (
optuna-dashboard
) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.Reference Issues/PRs
Follow up PR of #860
What does this implement/fix? Explain your changes.
JournalStorage
:errors
variables to prevent it.JournalStorage
:Infinity
,-Infinity
,NaN
.Reference