search

optuna / optuna-dashboard

Real-time Web Dashboard for Optuna.
https://optuna-dashboard.readthedocs.io/en/latest/
Other
477 stars 83 forks source link

Use tanstack table in tslib #882

Closed keisuke-umezawa closed 1 month ago

keisuke-umezawa commented 1 month ago

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code. This pull request may therefore be ported to Goptuna. Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

Reference Issues/PRs

NA

What does this implement/fix? Explain your changes.

Tanstack table was introduced in optuna-dashboard by https://github.com/optuna/optuna-dashboard/pull/846. This PR will also introduce it in tslib.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.51%. Comparing base (ac20f25) to head (0beb2af). Report is 189 commits behind head on main.

:exclamation: Current head 0beb2af differs from pull request most recent head f747a55

Please upload reports for the commit f747a55 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #882 +/- ## ======================================= Coverage 69.51% 69.51% ======================================= Files 35 35 Lines 2375 2375 ======================================= Hits 1651 1651 Misses 724 724 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

keisuke-umezawa commented 1 month ago

@porink0424 Thank you for reviewing. I restored initialRowsPerPage.