Update pytorch lightning version for ddp

optuna / optuna-examples

Examples for https://github.com/optuna/optuna

MIT License

634 stars 172 forks source link

Update pytorch lightning version for ddp #179

Closed Alnusjaponica closed 1 year ago

Alnusjaponica commented 1 year ago

Motivation

Support DDP for PyTorch Lightning as it is supported in optuna/optuna.

Description of the changes

This PR

replaces deprecated arguments with recommended ones
adds manual evoking of callback.check_pruned() as changed in optuna/optuna#4384.

Please merge this PR after optuna/optuna#4384 is merged into the optuna/optuna:master.

Alnusjaponica commented 1 year ago

The test will pass after https://github.com/optuna/optuna/issues/4499 is merged.

toshihikoyanase commented 1 year ago

Thank you for letting me know. Let me check this PR.

Alnusjaponica commented 1 year ago

I seems PyTorchLightningPruningCallback itself have not affected by the version update to PyTorch Lightning==2.0.0, so I remove the version constraint.