search

optuna / optuna-examples

Examples for https://github.com/optuna/optuna
MIT License
634 stars 172 forks source link

Updating the PyTorch Lightning example to >= 2.0 #204

Closed jxtngx closed 8 months ago

jxtngx commented 9 months ago

👋 Is it okay if I submit a PR to update the PyTorch Lightning example to use version 2.0?

toshihikoyanase commented 9 months ago

Thank you for your interest. Since Optuna v3.3.0 supports PyTorch Lightning 2.0, your contribution to update the example would be very helpful for users.

c-bata commented 9 months ago

Just a question, but it seems that the example is already using the latest version of PyTorch Lightning. Is it that some of the syntax is outdated, or are there any deprecated features being used?

https://github.com/optuna/optuna-examples/blob/e61dedae835adddd4bca45eb219683019bac279a/pytorch/requirements.txt#L4

jxtngx commented 9 months ago

Yes to the syntax. Essentially I would only need to update to >=2.0, run any needed tests to ensure everything is fine (as it should be since this currently installs PL 2.09), and push to the PR branch.

c-bata commented 9 months ago

Sounds good! Please proceed with the updates. Much appreciated!

github-actions[bot] commented 8 months ago

This issue has not seen any recent activity.