search

optuna / optuna-integration

Extended functionalities for Optuna in combination with third-party libraries.
https://optuna-integration.readthedocs.io/en/latest/index.html
MIT License
39 stars 30 forks source link

Move `SkoptSampler` #74

Closed Alnusjaponica closed 9 months ago

Alnusjaponica commented 9 months ago

Motivation

Progress https://github.com/optuna/optuna/issues/4484

Description of the changes

No tests have transferred since SkopSampler is highly unrecommended and not tested in optuna/optuna

codecov[bot] commented 9 months ago

Codecov Report

Attention: 169 lines in your changes are missing coverage. Please review.

Comparison is base (dec6d6c) 64.87% compared to head (84c5251) 59.65%.

:exclamation: Current head 84c5251 differs from pull request most recent head 2528ce6. Consider uploading reports for the commit 2528ce6 to get more accurate results

Files Patch % Lines
optuna_integration/skopt.py 0.00% 169 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #74 +/- ## ========================================== - Coverage 64.87% 59.65% -5.22% ========================================== Files 26 27 +1 Lines 1933 2102 +169 ========================================== Hits 1254 1254 - Misses 679 848 +169 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

y0z commented 9 months ago

I think these comments have not been resolved.

perhaps, scikit-optimize needs to be added to pyproject.toml (cf. here), because this PR does not include any tests, could you provide minimal code like the one below to verify the SkoptSampler works as intended for reviewers?

I've made another PR (https://github.com/optuna/optuna-integration/pull/78) as a follow-up task. Note that our CI cannot detect dependency errors because no tests are prepared for SkoptSampler.