search

optyfr / JRomManager

Java Rom Manager
https://discord.gg/rx6nwn6CGJ
GNU General Public License v2.0
179 stars 12 forks source link

Official Docker image #142

Closed taalas closed 1 year ago

taalas commented 2 years ago

Hi,

I am not sure how feasible this is, but have you considered providing an official docker image for this project? I imagine it being very well suited to run directly on a NAS system holding the files e.g.

optyfr commented 2 years ago

Seems that it concerns the web server mode, isn't it?

taalas commented 2 years ago

Exactly. I know that JDownloader2 is doing something similar in docker. It exposes the web server gui to the user. Maybe something similar could be applied here?

optyfr commented 2 years ago

yes should be feasible, in fact a lot of docker services are written in java, for example : sonarqube, jenkins, ...

taalas commented 2 years ago

Anything I can do to help with this?

optyfr commented 2 years ago

Not sure, I need time, and currently I started entire rewrite into javafx for the desktop interface, so this need to be finished first

taalas commented 2 years ago

Sure, I understand. Just for the sake of completeness here is the base image JDownloader2 uses to expose the GUI: https://github.com/jlesage/docker-baseimage-gui

optyfr commented 2 years ago

Thanks but the purpose is not the same, this docker image is for displaying graphical apps inside a web browser using vnc… whereas JRomManager as already a complete web client and can work headless without tricks Anyway it’s good to know that it’s also possible to run desktop apps through docker

AROAH1337 commented 2 years ago

All one would need to do is create a Dockerfile that essentially just runs the commands required to configure a basic installation from scratch. I'll add this to my list of projects in case no one else gets to it in the meantime.

optyfr commented 2 years ago

While a Dockerfile would be enough to just say : "Hey! JRomManager can run with docker!", but since the purpose is to do an "Official Docker image", the main challenge here is to publish a docker image into the docker hub automatically from github actions each time there is release tag event

optyfr commented 1 year ago

Please see https://hub.docker.com/r/optyfr/jrommanager