search

opulo-inc / farm-upload

A bulk file uploading tool for 3D printer farms.
https://opulo.io/
Other
36 stars 13 forks source link

Add type annotations #12

Open CoolCat467 opened 3 months ago

CoolCat467 commented 3 months ago

This pull request adds type annotations to the project and fixes a bug.

Bug is that currently, when reattempting to send, crashes from AttributeError because "Printer" objects are not indexable. https://github.com/opulo-inc/farm-upload/blob/73c363aa653e882104f44a029bf3e52edf28e5d9/src/FarmUpload.py#L114 I predict in an earlier version, printer details were stored purely in a dictionary, and this branch was missed when updating, and would have been caught with type checking.

CoolCat467 commented 2 months ago

@sphawes It's been a couple of months now, what is the status of this? Should I close this?