adding support in geo location of a photo

opus1269 / photo-screen-saver

A Chrome Extension providing a screen saver with custom photo sources. Developed with Polymer Web Components

https://chrome.google.com/webstore/detail/kohpcmlfdjfdggcjmjhhbcbankgmppgc

Other

21 stars 10 forks source link

adding support in geo location of a photo #11

Closed KingAMS closed 7 years ago

opus1269 commented 7 years ago

Thanks.

Several people have asked for this.

Looks very clean at first glance.

I'm in the middle of a bunch of changes (working branch). Promisefying everything, improved analytics, other stuff. Touched pretty much everything. I'll take a look at your changes and see how best to merge it all together.

KingAMS commented 7 years ago

10x Please let me know if u have any q.

opus1269 commented 7 years ago

I merged in your (modified) changes to the master branch aa54368

The main changes I made to your stuff:

Add a simple cache to minimize the calls to the Maps API (also put geo stuff in own file geo.js)
Cleanup handling of label displays in frame mode
I also fixed a bug that I introduced not too long ago.

If you get a chance, please take a look and see if I missed anything you intended.

opus1269 commented 7 years ago

Closed by aa54368

KingAMS commented 7 years ago

Looks great ! 10x