opus1269 / photo-screen-saver

A Chrome Extension providing a screen saver with custom photo sources. Developed with Polymer Web Components
https://chrome.google.com/webstore/detail/kohpcmlfdjfdggcjmjhhbcbankgmppgc
Other
21 stars 10 forks source link

Screensaver starts even when watching full screen video #14

Open yang opened 7 years ago

yang commented 7 years ago

First: Brilliant extension!

Normally, the OS screen saver does not auto start when a full screen video is playing (either in a web page, e.g. Netflix/YouTube, or in an application, e.g. VLC/QuickTime). However, this extension does auto start the screen saver under such conditions. Is there any way to prevent this? This seems to be the major barrier preventing this from being usable for us (regular watchers of full screen video, probably like many others). It also doesn't seem to necessarily always do this - sometimes we see the window try to start, but then vanish, revealing the video again. But other times it just starts right over the video.

Thank you!

opus1269 commented 7 years ago

Yang,

In the settings on the "DISPLAY CONTROLS" tab is an option "Do not show over fullscreen Chrome windows". If this is set it won't display over any full screen Chrome window {e.g. Netflix, Youtube).

Unfortunately, I haven't been able to figure out a way to detect a full screen window in applications other than Chrome from the extension. In this case the best you can do is toggle the enabled state of the screensaver. The easiest way to do this is to press Alt+Shift+Q while Chrome has the focus or right click on the extension icon and select the Enable/Disable menu. The badge text will change on the icon to let you know about the state change. You can also make the Alt+Shift+Q shortcut work globally (or change it to something else. Go to “More tools” -> “Extensions, scroll to the bottom and click on “Keyboard shortcuts”. Find the Photo Screen Saver extension and enter the key combination you want to use for “Toggle enabled state”. Actually press the combination you want to use, don’t try to spell it out.

I can take another look at detecting full screen non-Chrome windows, to see if I missed something.

About the screensaver trying to start then vanishing: That surprises me. It should never happen if the video in question is from a full screen Chrome window. If it is from another application I suppose it could happen - the only things that can make the screensaver go away are: if the mouse moves, if the mouse is clicked, if a key is pressed, or if the idle state of the computer changes. If you can figure out when the screensaver tries to show then vanishes, please let know.

yang commented 7 years ago

Sorry I should have mentioned, the disable showing over full screen option is already enabled, and this is definitely still happening. Most of the time it just shows, without vanishing.

On Fri, Jun 16, 2017, 11:35 PM opus1269 notifications@github.com wrote:

Yang,

In the settings on the "DISPLAY CONTROLS" tab is an option "Do not show over fullscreen Chrome windows". If this is set it won't display over any full screen Chrome window {e.g. Netflix, Youtube).

Unfortunately, I haven't been able to figure out a way to detect a full screen window in applications other than Chrome from the extension. In this case the best you can do is toggle the enabled state of the screensaver. The easiest way to do this is to press Alt+Shift+Q while Chrome has the focus or right click on the extension icon and select the Enable/Disable menu. The badge text will change on the icon to let you know about the state change. You can also make the Alt+Shift+Q shortcut work globally (or change it to something else. Go to “More tools” -> “Extensions, scroll to the bottom and click on “Keyboard shortcuts”. Find the Photo Screen Saver extension and enter the key combination you want to use for “Toggle enabled state”. Actually press the combination you want to use, don’t try to spell it out.

I can take another look at detecting full screen non-Chrome windows, to see if I missed something.

About the screensaver trying to start then vanishing: That surprises me. It should never happen if the video in question is from a full screen Chrome window. If it is from another application I suppose it could happen

  • the only things that can make the screensaver go away are: if the mouse moves, if the mouse is clicked, if a key is pressed, or if the idle state of the computer changes. If you can figure out when the screensaver tries to show then vanishes, please let know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opus1269/photo-screen-saver/issues/14#issuecomment-309197180, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAb2Vxkc56wo2N9D_x16l0Hw-QnhFs2ks5sE3O-gaJpZM4N9IOi .

opus1269 commented 7 years ago

Darn. Are you on a Mac? That is the one device I don't have for testing.

If you are, I'll ask a buddy if I can use his for a while to debug it.

yang commented 7 years ago

I am indeed on a Mac!

Thank you for digging into this.

On Sat, Jun 17, 2017, 12:23 AM opus1269 notifications@github.com wrote:

Darn. Are you on a Mac? That is the one device I don't have for testing.

If you are, I'll ask a buddy if I can use his for a while to debug it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/opus1269/photo-screen-saver/issues/14#issuecomment-309199078, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAb2RScKIWZZ9E6SRUvmtzDSmdoj5Vuks5sE379gaJpZM4N9IOi .

ManpreetSingh80 commented 6 years ago

25 Address this issue