search

opws / opws-dataset

Profiles for the user account systems of various sites.
Open Data Commons Open Database License v1.0
14 stars 2 forks source link

Unify around POSIX character class names #288

Closed stuartpb closed 7 years ago

stuartpb commented 7 years ago

This is another thing I've been thinking about for a while but never gone forward with: the terminology of character classes used across every file have been inconsistent at best. Post-#146, this will be untenable, so I decided to go all-in on POSIX's character class names, which may be occasionally cryptic (I'm actually considering pulling alnum out of the list for that exact reason, making it just be alpha and digit), but do have a single definition that I'm not trying to struggle to invent and wrangle.

stuartpb commented 7 years ago

So, I've gone ahead and accepted this, and it's shipping with v0.1.0, but I could make a compelling argument that it should be backed out for v0.2.0. I think, if I do this, it'll be after all the outstanding schema issues currently in this repo are migrated to the schemata repo.

stuartpb commented 7 years ago

That said, I am going to yank alnum before v0.1.0, because there's only one place where I used it, and it's way more bizarre than the rest.