oqtane / DNF.Projects

Sample Oqtane module demonstrating a scheduled job and JSInterop visualizations using Chart.js. This module powers the trend analysis on https://dnfprojects.org.

https://dnfprojects.org/

MIT License

25 stars 17 forks source link

Bug: Chart Stats are not being displayed in the line chart. #9

Closed thabaum closed 4 months ago

thabaum commented 4 months ago

Issue

Description

Stats not displayed properly with the line chart.

Steps to Reproduce

Click on the magnifying glass icon to view stat details
Notice the lines are flat and not representing the data presented.

Screenshot

sbwalker commented 4 months ago

@thabaum the graph is correct... the problem is the scale of the various metrics... and the fact that the trend lines increase very gradually.

thabaum commented 4 months ago

You are correct.

If you select a time frame it should probably change the graph similar to how it does it in GitHub for contributors commits. Might have to change the range from 0 to 100 for example to graph from 80-100 to see there is activity for the month where 81-100 data is presented and added in that month.

I see your post above now, and is delayed response here, so that is the issue you mentioned above.

thabaum commented 4 months ago

@sbwalker I now see it looks OK when you select just the one category.

thabaum commented 4 months ago

maybe the default can be the default metric used on the home page.

sbwalker commented 4 months ago

the current module is only intended to be an example and it is serving the needs of https://dnfprojects.com so I do not intend to add enhancements to this project at this time.

thabaum commented 4 months ago

Sounds good. It works as is, I do notice the pager could be enhanced in Oqtane Framework to show the other pages to click on.

I will maybe put an enhancement request down the road for this once so if you have 2 -5 pages or so they show up as links you can click on or hit the arrow icon. For now focus on stabilizing 5.1.

So it works more like this:

Instead of this:

This is just some feedback other than that as the chart does work so there isn't any kind of real fire to put out.

sbwalker commented 4 months ago

@thabaum the Pager component already supports the ability to display pages which can be clicked. The DNF.Projects module is configured to only show the current page because it is optimized for mobile viewing - where the horizontal screen real estate is limited. If you look at the any of the Admin screens in Oqtane you will see they display 3 clickable pages by default.