thank you for the development of this amazing package! :)
I would like to report a minor bug in the function check_termination in pccg_solver.py.
If execute_PCCG_solver reaches its iteration-limit and the terminition is checked, while the solver config.quiet-parameter is set True, check_termination is called and raises the RuntimeError(f'Error: Upper bound greater than lower bound after {k} iterations and {elapsed} seconds: Obj={LB} UB={UB}'). However, this is resulting in a NameError as k (and elapsed) is not provided to the check_termination-function.
If PRs are considered, I would be happy to solve this Issue.
Dear pao-Team,
thank you for the development of this amazing package! :) I would like to report a minor bug in the function
check_terminationinpccg_solver.py. Ifexecute_PCCG_solverreaches its iteration-limit and the terminition is checked, while the solverconfig.quiet-parameter is set True,check_terminationis called and raises theRuntimeError(f'Error: Upper bound greater than lower bound after {k} iterations and {elapsed} seconds: Obj={LB} UB={UB}'). However, this is resulting in a NameError as k (and elapsed) is not provided to thecheck_termination-function. If PRs are considered, I would be happy to solve this Issue.Thank you in advance! Best, Kirill Kuroptev