search

oracc / nammu

Oracc GUI
GNU General Public License v3.0
12 stars 10 forks source link

Clarify error messages from validation/lemmatiser #134

Closed jenshnielsen closed 8 years ago

jenshnielsen commented 8 years ago

Consider

cams/gkab/00atf/ctn_4_008.atf

Validation returns

The validation returned no errors. Yet

Lemmatisation returns 

The server returned some errors: 
00atf/ctn_4_008.atf:140:P363423: (lem) %akk-x-stdbab:IZI.GAR=+niphu[(the act of) lighting//anger]N$niphi: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:143:P363423: (lem) %akk-x-stdbab:SILIM=+salāmu[be(come) at peace//reconcile]V$isallimū: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:146:P363423: (lem) %akk-x-stdbab:NIM=+elû[go up//elevate]V$ulla: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:178:P363423: (lem) %akk-x-stdbab:il-la-a=+elû[go up//rise]V$illâ: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:224:P363423: (lem) %akk-x-stdbab:um-ma-an=+ummiānu[expert//scholar]N$ummân: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:233:P363423: (lem) %akk-x-stdbab:per-u=+perʾu[bud//descendant(s)]N$: must give EPOS when giving SENSE with new lemm
ATF processor ox issued 6 warnings and 0 notices

You can't lemmatise a file that is not valid.
Please, see highlighted areas and correct  errors.
jenshnielsen commented 8 years ago

The lemmatisation message should probably just be tweaked slightly

raquelalegre commented 8 years ago

I'll change the error message from the lemmatisation and ask Steve and Eleanor to clarify on the differences of the validation stage during the lemmatisation.

My understanding was the lem command sent to the server for lemmatisation was running first the atf command for validation, which is the one sent when the user chooses to only validate the text.

raquelalegre commented 8 years ago

Changed in #135 so that now it looks like this when lemmatising:

The lemmatisation returned some errors: 
00atf/ctn_4_008.atf:140:P363423: (lem) %akk-x-stdbab:IZI.GAR=+niphu[(the act of) lighting//anger]N$niphi: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:143:P363423: (lem) %akk-x-stdbab:SILIM=+salāmu[be(come) at peace//reconcile]V$isallimū: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:146:P363423: (lem) %akk-x-stdbab:NIM=+elû[go up//elevate]V$ulla: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:178:P363423: (lem) %akk-x-stdbab:il-la-a=+elû[go up//rise]V$illâ: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:224:P363423: (lem) %akk-x-stdbab:um-ma-an=+ummiānu[expert//scholar]N$ummân: must give EPOS when giving SENSE with new lemm
00atf/ctn_4_008.atf:233:P363423: (lem) %akk-x-stdbab:per-u=+perʾu[bud//descendant(s)]N$: must give EPOS when giving SENSE with new lemm
ATF processor ox issued 6 warnings and 0 notices

Please, see highlighted areas and correct errors.

Sent email to Steve as well to ask for clarification on how the validation stage during lemmatisation is different.

raquelalegre commented 8 years ago

Blocked as waiting to hear from Steve/Eleanor.

raquelalegre commented 8 years ago

Eleanor says better ask Steve. I'm not sure we really need to prompt him for details on this. It'd be good to know, but it doesn't really impact Nammu much apart from the error message that is now corrected, so this issue can be closed I guess @jenshnielsen ?