search

oracc / nammu

Oracc GUI
GNU General Public License v3.0
12 stars 10 forks source link

Check if Nammu can empty local settings file #344

Closed raquelalegre closed 4 years ago

raquelalegre commented 6 years ago

A user seems to have a problem with her settings file being empty (#339). We don't know the cause, but it'd be worth to check if there's anywhere in Nammu's codebase where the settings file is emptied by some error not being handled properly.

The last line in Nammu's log for this user was an edition of the settings, although a very common one that is all over her log, so it might not be the cause. See https://github.com/oracc/nammu/files/2311637/nammu.log.

raquelalegre commented 5 years ago

@ageorgou pointed out that we are opening the settings file in wb mode, when we just want to read it. This might cause the file becoming empty. We don't really need wb mode, so it might be an easy fix.

Still worth checking if there's other error handling section that might cause the settings file to get emptied when it shouldn't.

ageorgou commented 5 years ago

Might be related with #347?

giordano commented 4 years ago

We recently improved handling of errors of empty settings files (#406), in the process we couldn't find how they can be emptied by Nammu, so I'm closing this issue.