search

oracc / nammu

Oracc GUI
GNU General Public License v3.0
12 stars 10 forks source link

Fix focus when undoing #382

Closed giordano closed 5 years ago

giordano commented 5 years ago

This is my initial attempt at fixing #371. There are two separate issues here:

  1. focus stays in the current pane even if the edit being undone is in another pane
  2. only when syntax highlighting is on, the caret moves to the second line of the edit area if this panel has focus and the edit to be undone is in the other pane

Currently this PR fixes the first issue, I marked it as draft because it's not yet complete, as I have to:

giordano commented 5 years ago

I'd suggest reviewing this PR in its current state. I think it completely addresses one issue (focus when undoing/redoing), the position of the caret is unrelated, even though they concur in #371.

ageorgou commented 5 years ago

@giordano Can you rebase on development (or merge that in)? Some of the test failures are because of Travis version issues which have been fixed in other PRs.