search

oracc / nammu

Oracc GUI
GNU General Public License v3.0
12 stars 10 forks source link

Compute limit of syntax highlighting with self.styledoc.getLengt… #394

Closed giordano closed 5 years ago

giordano commented 5 years ago

Fix #393.

As it is now, NammuController.arabicIndex is of little utility as it is only set when opening a new file and never again, thus I simply removed it. In this PR I propose to use self.styledoc.getLength() to compute the upper limit of syntax highlighting when we have a file with an Arabic translation.

raquelalegre commented 5 years ago

Oops, just approved and then noticed the test failing. Probably a glitch? Try to run again before merging.

giordano commented 5 years ago

Tests pass locally, I'd think it's a Travis+Nammu glitch

giordano commented 5 years ago

All green now! I'm going to merge