search

oracc / nammu

Oracc GUI
GNU General Public License v3.0
12 stars 10 forks source link

Simplify version checking and patching #403

Closed ageorgou closed 4 years ago

ageorgou commented 5 years ago

At statup, Nammu checks the user's existing settings and compares them to the version in the jar, to determine if any update or patching is needed. This is currently done twice, with no obvious reason for doing so (once in update_yaml_config, and then again in get_yaml_config directly). It would be nice to clear that up, unless it turns out it's needed (unlikely).

giordano commented 5 years ago

For reference, the version checking inside get_yaml_config has been introduced in commit https://github.com/oracc/nammu/commit/d422d8ad72b269cff323f41cefd03b4afd3772c6 (PR #293). I'm not sure what kind of problem this was meant to fix though

ageorgou commented 5 years ago

Hm. The version checking was introduced there, but the patching was already present in both places before that. It seems it was introduced in #292 - I wonder who reviewed that 😅

giordano commented 5 years ago

Related to this, @ageorgou suggested to close the setting files at some point