search

oracc / nisaba

GNU General Public License v3.0
3 stars 0 forks source link

Move CI to GitHub Actions #113

Closed giordano closed 2 years ago

giordano commented 2 years ago

I also added the step to automatically publish the extension if we're running the tests on a release tag. I created the relevant secret, so in principle this should all work. ~We can later automate also the creation of the tag.~ Edit: not sure it's worth the effort

giordano commented 2 years ago

I tried all steps, excluding publishing to the Marketplace, in a private repository. Seems to be working well. When we create a new release on GitHub the package is always automatically uploaded there as an asset, but the package isn't published to the marketplace if the release is marked as pre-release in GitHub.

Edit: I also created a workflow dispatch to automatically create git tag and GitHub release page out of the version number in package.json, so that we have a single place where the version number is specified and ensure consistency. Note that this workflow would fail if the tag already exists, which I think is reasonable. This workflow will then automatically trigger the CI job to run the test and publish the extension.

ageorgou commented 2 years ago

Given that failures are down to server communication which hasn't changed, and that the tests were passing just before some unrelated changes, I think we can merge this in the interest of having a new release.