Enhance arabic preview - Githubissues

oracc / nisaba

GNU General Public License v3.0

3 stars 0 forks source link

Enhance arabic preview #49

Closed ageorgou closed 3 years ago

ageorgou commented 3 years ago

Live updates
Open preview in separate column

These are quite rough and there are some doubts about how best to dispose of things, so if someone understands the lifecycle of extensions better, comments are welcome :)

ageorgou commented 3 years ago

I'd like to clean things up a bit before we merge, specifically:

[x] rename things properly
[x] possibly move to its own file
[x] check that we are setting up the disposal correctly

ageorgou commented 3 years ago

Have changed it so the preview pane is cleared (but stays open) if the user switches to a non-ATF file.

It would be nice to have tests but we'll have to first look at how to simulate GUI actions. I suggest we leave that for a future PR.