search

oracc / oracc-search-front-end

1 stars 1 forks source link

removing homecomponent #61

Closed acholyn closed 7 months ago

acholyn commented 8 months ago

Does the breadcrumb function need to be updated?

jhughes982 commented 7 months ago

I can't give a thorough review of your code right now unfortunately. But I spotted that you have included your package-lock.json file to gitignore. Unless you have a specific reason to do so, this file should generally be included in source control.

https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

tim-band commented 7 months ago

Should merge in the dev branch.

tim-band commented 7 months ago

Need to .gitignore cypress/screenshots

acholyn commented 7 months ago

I tried the command for the unit tests and the window opens saying complete but also says there were no specs found. Are there no unit tests or is this broken?

acholyn commented 7 months ago

Should merge in the dev branch.

I'm apparently up to date - perhaps because I built this branch off development recently and then merged in the cypress stuff from longer ago

tim-band commented 7 months ago

There are two more /search/search-results/ in the project.