search

oracc / oracc-search-front-end

1 stars 1 forks source link

CSS only mobile #76

Open tim-band opened 1 month ago

tim-band commented 1 month ago

Almost all mobile/desktop differences are removed from the Angular code. CSS does everything except scrolling to the correct transliteration on clicking the translation, and deciding whether the left and right panels default to open or closed.

Fixes #71 Fixes #26 Fixes #8

acholyn commented 3 weeks ago

We still seem to be using the isMobile attr in the panel, details and project texts, are these to be updated or can they be removed?

tim-band commented 3 weeks ago

We still seem to be using the isMobile attr in the panel, details and project texts, are these to be updated or can they be removed?

We are using isMobile to determine whether to start the three-panel displays with the first and third panels open (desktop) or closed (mobile). But it would be reasonable also to remove it from there, too, and rely on scrolling the middle panel into view to get a similar effect.

What do you think?

acholyn commented 3 weeks ago

Ah, ok. Not entirely sure what you mean by scrolling the middle panel, but if we can't do the collapsing in CSS then I think it's ok to have this as an exceptional use of isMobile