search

oracc / pyoracc

Python tools for working with ORACC
GNU General Public License v3.0
12 stars 10 forks source link

C-ATF processing and ORACC "ox" ATF processor rules integration #66

Open epageperron opened 6 years ago

epageperron commented 6 years ago

As part of the MTAAC project, we are processing C-ATF data from the CDLI database. PyOracc looks like the tool that best fits most of our criteria to perform the job so we are planning on extending it to fully support C-ATF, partly basing ourselves on rules from @stinney 's ATF Processor. As such, we would be interested in working directly in a dev branch of your repository. We can also fork and create pull requests. Please let me know if there is an interest on your side. Thank you, Émilie

MTAAC: https://cdli-gh.github.io/mtaac CDLI: https://cdli.ucla.edu Team: /cdli-gh/mtaac-cdli-engineers

raquelalegre commented 6 years ago

Hi @epageperron ! Apologies for taking long to reply to your request. I was on leave and I'm still trying to catch up with email and work. It is very exciting to have someone reusing our code and contributing to it!

I think the best approach for your work would be to fork this repo, and then create pull requests (ideally linked to issues so we can trace back in the future if needed). You can assign the PRs to me or one of my colleagues (@sgrieve or @ageorgou). We have configured automatic testing, so that'll help us make sure the new changes don't break existing functionality, and at the same time we can learn from each other when reviewing your contributions.

Please let us know if you need any guidance. We haven't touched much of this code in a long time, but we can hopefully be of help! We could set up a Skype call to talk more about this if you need. Just let us know what works best for you.

raquelalegre commented 6 years ago

I have just created a new branch called c-atf (https://github.com/oracc/pyoracc/tree/c-atf) with the same content master has right now. If you fork the repo, you could create PRs to that branch, so we'll be maintaining at the same time the master branch that is used by Nammu, and your latest stable changes in the c-atf branch. Is that OK with you?

epageperron commented 6 years ago

Sounds perfect, thank you !

epageperron commented 6 years ago

Could you please also invite @starlordphr ?

raquelalegre commented 6 years ago

Done! :)

epageperron commented 6 years ago

Many thanks !