oracc / pyoracc

Python tools for working with ORACC
GNU General Public License v3.0
12 stars 10 forks source link

travis: Use the default osx image. #76

Closed rillian closed 5 years ago

rillian commented 5 years ago

XCode 7.3 (based on macOS 10.11) is out of support, and cannot complete tests because the brew upgrade step has so many packages to build. Use the default image instead, which is currently macOS 10.13 and Xcode 9.4.1.

This seems to resolve the recent travis test failures on macOS.

rillian commented 5 years ago

Note that the linux 2.7 python job has started failing in the meantime, so tests still won't be green with this commit. I suspect that can be fixed by removing coverage from that job as was done for the jython job, if that's a reasonable approach?

codecov-io commented 5 years ago

Codecov Report

Merging #76 into master will decrease coverage by 0.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #76     +/-   ##
=========================================
- Coverage   87.24%   87.14%   -0.1%     
=========================================
  Files          26       27      +1     
  Lines         980      988      +8     
=========================================
+ Hits          855      861      +6     
- Misses        125      127      +2
Impacted Files Coverage Δ
pyoracc/__init__.py 75% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b18c9e7...bb30753. Read the comment docs.

rillian commented 5 years ago

Adding Python 3.7 on Linux turned out to be a bridge too far, but the additional commit have all tests passing again. @jayanthjaiswal, @raquel-ucl what do you think?

jayanthkmr commented 5 years ago

@rillian Great work! Thanks. Removing coverage won't hurt much.

raquelalegre commented 5 years ago

Thanks @rillian!

rillian commented 5 years ago

Thanks for reviewing! I don't have commit access. Could someone please push the merge button so we can make the badge green? :)

giordano commented 5 years ago

There you go!

rillian commented 5 years ago

danke!