oracc / pyoracc

Python tools for working with ORACC
GNU General Public License v3.0
12 stars 10 forks source link

More test and warning fixes #77

Closed rillian closed 5 years ago

rillian commented 5 years ago
codecov-io commented 5 years ago

Codecov Report

Merging #77 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   87.14%   87.14%           
=======================================
  Files          27       27           
  Lines         988      988           
=======================================
  Hits          861      861           
  Misses        127      127
Impacted Files Coverage Δ
pyoracc/model/corpus.py 82.35% <100%> (ø) :arrow_up:
pyoracc/atf/common/atflex.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ea197a...48296b2. Read the comment docs.

rillian commented 5 years ago

Ha! I guess the disabled tests were redundant. :)

ageorgou commented 5 years ago

Thanks @rillian! It looks like the warning is raised by the Python interpreter itself, not pep8/pycodestyle, and it's not because of the unicode sequences but due to patterns like \/ and \.. This is because of a change in version 3.6 (hence why it only appears in the OS X build), which started warning silently about invalid escape sequences. This will become an error in a future version, so it's worth looking into at some point. I've opened #78 to record it.

ageorgou commented 5 years ago

Seems fine - the pytest version can be discussed in #79!

rillian commented 5 years ago

Thanks!