search

oracc / pyoracc

Python tools for working with ORACC
GNU General Public License v3.0
12 stars 10 forks source link

Fix remaining travis warnings #81

Closed rillian closed 5 years ago

rillian commented 5 years ago

Address the remaining escape sequence warnings, and replace deprecated pep8 with pycodestyle.

Closes #78 .

codecov-io commented 5 years ago

Codecov Report

Merging #81 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #81   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files          27       27           
  Lines         996      996           
=======================================
  Hits          869      869           
  Misses        127      127
Impacted Files Coverage Δ
pyoracc/atf/common/atflex.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c32960b...6959cd9. Read the comment docs.

rillian commented 5 years ago

@ageorgou I was just wondering if you've had time to look at this?

rillian commented 5 years ago

Ok @ageorgou, ready for follow-up!

ageorgou commented 5 years ago

Thanks @rillian! I'll take a look and also double check with someone who has more ATF experience, so it will be early next week when I can review with confidence.

rillian commented 5 years ago

Thanks for the update. Hopefully all the additional issues are addressed now.

rillian commented 5 years ago

Great, thanks! \o/ Can you also merge the PR for me?