Closed tonybolzan closed 1 year ago
Thanks! Have you signed the Oracle Contributor Agreement? If not, please visit https://oca.opensource.oracle.com to sign it. Adding another commit to the PR will also trigger the Bot to verify that it's been signed.
This probably needs some error checking/catching or restrictions to only be available for runners with a specific tag.
Can be a specific configuration on with:
? like allowPrivateAccess
or other better name.
What you think ?
steps:
- uses: oracle-actions/configure-kubectl-oke@v1
with:
cluster: ${{ secrets.OKE_CLUSTER_OCID }}
allowPrivateAccess: true
~That seems reasonable to me.~
Actually, let's go with enablePrivateEndpoint
and please update the docs to indicate that this requires a self-hosted runner with access to that endpoint.
Thanks! Have you signed the Oracle Contributor Agreement? If not, please visit https://oca.opensource.oracle.com to sign it. Adding another commit to the PR will also trigger the Bot to verify that it's been signed.
The OCA has bean rejected, I submited another trial with a updated information.
But this project is not in the OCA project list, so I had to select other
in the project list.
And I received this message Other: For "Other" project(s), reach out to the project owner(s) to add the project(s) to the system.
on this form
I have added the project to the OCA application, so you should be able to submit now. Sorry for the hurdles, but you're the first person to submit a PR to any of our actions. :)
I'm waiting for the OCA to be approved to update the PR.
I just approved it, you should be good to go.
PR Updated, you can review.
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.
When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.
If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.
I merged this manually, so closing the PR.
Private connections in k8s Cluster is a desired security tip. And running a self-hosted runner in a private VCN can accomplish the connections without a public IP.
With this modification public and private connections are allowed without braking compatibility.