search

oracle-actions / configure-kubectl-oke

Install and configure Kubectl for the specified Oracle Engine for Kubernetes (OKE) cluster
Universal Permissive License v1.0
10 stars 8 forks source link

ARM64 support for kubectl #28

Open galovics opened 5 months ago

galovics commented 5 months ago

Currently the architecture is hardcoded in the download URL for kubectl at https://github.com/oracle-actions/configure-kubectl-oke/blob/main/src/main.ts#L27

An extra parameter could be added to configure the target architecture, defaulting to amd64 to not break any existing usage of the action.

Djelibeybi commented 5 months ago

Good suggestion, thanks.

Djelibeybi commented 5 months ago

I guess it would be better to populate this based on the architecture of the runner on which the action is currently running as opposed to requiring the user to configure it correctly.

galovics commented 5 months ago

@Djelibeybi agreed. I was just thinking of the configuration (after spending a good amount of time) to make this as easy to implement as possible.

In the meantime, I came across the setup-helm action as well and I saw those guys have implemented it. Probably copying it would be the easiest.

https://github.com/Azure/setup-helm/blob/main/src/run.ts#L110

galovics commented 1 month ago

@Djelibeybi had some spare time, did a PR, pls take a look: https://github.com/oracle-actions/configure-kubectl-oke/pull/31