oracle-contributor-agreement[bot]
commented
4 months ago Thank you for signing the OCA.
Closed galovics closed 4 months ago
oracle-contributor-agreement[bot]
commented
4 months ago Thank you for signing the OCA.
Djelibeybi
commented
4 months ago I'm on leave until early June, so I'll take a look next week. In the meantime, please remove the .js file from the PR, just leave the TypeScript file.
galovics
commented
4 months ago Will do @Djelibeybi, wasn't sure if that's needed so did the bundle generation anyway.
Djelibeybi
commented
4 months ago It may be worth waiting until I merge #32 which retrofits some CI stuff and bumps a bunch of dependencies to newer versions too.
galovics
commented
4 months ago @Djelibeybi sure thing, let me know when there's something to do for this PR.
Djelibeybi
commented
4 months ago Sorry for the delay. I'm just in the middle of some internal changes which have resulted in the testing tenancy for these actions going away. I'm trying to find a replacement tenancy so that we can test these changes before merging.
galovics
commented
4 months ago alright, thanks for the update
Djelibeybi
commented
4 months ago Merged via #35
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). The following contributors of this PR have not signed the OCA:
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.
When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.
If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.