oracle-actions / setup-java

GitHub Action to download and install Oracle's Java Development Kit builds
Universal Permissive License v1.0
63 stars 11 forks source link

[feature] Include external JDK code tools through action options #31

Closed denismakogon closed 2 years ago

denismakogon commented 2 years ago

As you may know, jextract wouldn't be a part of the JDK distro due to its size (and a few other reasons). I guess setup-java should provide options to provide the JDK with jextract under the $JAVA_HOME/bin path.

delabassee commented 2 years ago

This action is about downloading and installing JDK builds, built by Oracle. By supporting jextract, we would expand its scope, and make its maintenance more complex.

Moreover, jextract is not available, today, in a binary form so it would have to be built first. Finally, a native toolchain will also be required most of the time, so the user would have to install additional bits anyway.

Let's revisit this at some point if it ever makes sense, ex. a dedicated "oracle-actions/setup-java-tools" action ?

delabassee commented 2 years ago

FYI, https://jdk.java.net/jextract/ now offers EA jextract binaries.

sormuras commented 2 years ago

As jextract binaries are distributed as a custom runtime image using the default format produced by jlink, users may now install jextract in their GitHub Actions workflows as follows:

    - uses: oracle-actions/setup-java@v1
      with:
        website: jdk.java.net
        release: jextract