search

oracle-actions / setup-java

GitHub Action to download and install Oracle's Java Development Kit builds
Universal Permissive License v1.0
62 stars 11 forks source link

Update to Java 20 #54

Closed scordio closed 1 year ago

scordio commented 1 year ago

JDK 20.0.1 has been released ~today~ yesterday and I've noticed some failures like this one.

I've taken inspiration from #41 for a fix, I hope I covered all the needed points.

scordio commented 1 year ago

Looks good so far 👍 https://github.com/assertj/assertj/actions/runs/4739705996/jobs/8420640816

Thanks for merging!

sormuras commented 1 year ago

The run you linked indicates that only the mapping file update was missing - as your workflow uses v1 of oracle-actions/setup-java. That update would/should have happend automatically today/or so.

Thanks for updating the defaults and documentation - we will release a new version of this action soon, with moving the v1 branch to that new release as well.

scordio commented 1 year ago

Wasn't the mapping file updated with 33f8639ae0bbc8bdaee0773d831dcb39c58e839d? Not sure I understood where the gap was.

sormuras commented 1 year ago

Yes, you are right. The mapping was updated; yet the parser/lister (ListOpenJavaDevelopmentKits.java) was out of sync. This is what your PR fixed and generated the new mapping file - which now consumable by current @v1 and @main versions of this action alike.